Re: [PATCH 1/1 net-next] net/atm/signaling.c: replace current->state by __set_current_state()

2015-02-23 Thread David Miller
From: chas williams - CONTRACTOR Date: Mon, 23 Feb 2015 12:50:25 -0500 > Instead of fixing code that never gets compiled/test, you could probably > just remove the #if WAIT_FOR_DAEMON code which would get rid of this > raw assignment. > > See the #undef around line 268. I completely agree. --

Re: [PATCH 1/1 net-next] net/atm/signaling.c: replace current->state by __set_current_state()

2015-02-23 Thread chas williams - CONTRACTOR
Instead of fixing code that never gets compiled/test, you could probably just remove the #if WAIT_FOR_DAEMON code which would get rid of this raw assignment. See the #undef around line 268. On Mon, 23 Feb 2015 18:31:07 +0100 Fabian Frederick wrote: > Use helper functions to access

[PATCH 1/1 net-next] net/atm/signaling.c: replace current->state by __set_current_state()

2015-02-23 Thread Fabian Frederick
Use helper functions to access current->state. Direct assignments are prone to races and therefore buggy. Thanks to Peter Zijlstra for the exact definition of the problem. Suggested-By: Peter Zijlstra Signed-off-by: Fabian Frederick --- net/atm/signaling.c | 2 +- 1 file changed, 1

[PATCH 1/1 net-next] net/atm/signaling.c: replace current-state by __set_current_state()

2015-02-23 Thread Fabian Frederick
Use helper functions to access current-state. Direct assignments are prone to races and therefore buggy. Thanks to Peter Zijlstra for the exact definition of the problem. Suggested-By: Peter Zijlstra pet...@infradead.org Signed-off-by: Fabian Frederick f...@skynet.be --- net/atm/signaling.c | 2

Re: [PATCH 1/1 net-next] net/atm/signaling.c: replace current-state by __set_current_state()

2015-02-23 Thread chas williams - CONTRACTOR
Instead of fixing code that never gets compiled/test, you could probably just remove the #if WAIT_FOR_DAEMON code which would get rid of this raw assignment. See the #undef around line 268. On Mon, 23 Feb 2015 18:31:07 +0100 Fabian Frederick f...@skynet.be wrote: Use helper functions to access

Re: [PATCH 1/1 net-next] net/atm/signaling.c: replace current-state by __set_current_state()

2015-02-23 Thread David Miller
From: chas williams - CONTRACTOR c...@cmf.nrl.navy.mil Date: Mon, 23 Feb 2015 12:50:25 -0500 Instead of fixing code that never gets compiled/test, you could probably just remove the #if WAIT_FOR_DAEMON code which would get rid of this raw assignment. See the #undef around line 268. I