Re: [PATCH 1/1 v4] pwm_bl: Add support for backlight enable regulator

2013-03-07 Thread Thierry Reding
drew Chew; linux-kernel@vger.kernel.org > >>Subject: Re: [PATCH 1/1 v4] pwm_bl: Add support for backlight enable > >>regulator > >> > >>* PGP Signed by an unknown key > >> > >>On Thu, Mar 07, 2013 at 07:11:25PM +0900, Alex Courbot wrote: > >>&g

Re: [PATCH 1/1 v4] pwm_bl: Add support for backlight enable regulator

2013-03-07 Thread Alex Courbot
On 03/08/2013 06:07 AM, Andrew Chew wrote: From: Thierry Reding [mailto:thierry.red...@avionic-design.de] Sent: Thursday, March 07, 2013 3:27 AM To: Alex Courbot Cc: Andrew Chew; linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1 v4] pwm_bl: Add support for backlight enable regulator * PGP

RE: [PATCH 1/1 v4] pwm_bl: Add support for backlight enable regulator

2013-03-07 Thread Andrew Chew
> From: Thierry Reding [mailto:thierry.red...@avionic-design.de] > Sent: Thursday, March 07, 2013 3:27 AM > To: Alex Courbot > Cc: Andrew Chew; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 1/1 v4] pwm_bl: Add support for backlight enable > regulator > > * PGP

Re: [PATCH 1/1 v4] pwm_bl: Add support for backlight enable regulator

2013-03-07 Thread Thierry Reding
On Thu, Mar 07, 2013 at 07:11:25PM +0900, Alex Courbot wrote: > On 03/07/2013 04:11 PM, Thierry Reding wrote: > >>+ boolen_supply_enabled; > > > >This boolean can be dropped. As discussed in a previous thread, the > >pwm-backlight driver shouldn't need to know about any other

Re: [PATCH 1/1 v4] pwm_bl: Add support for backlight enable regulator

2013-03-07 Thread Alex Courbot
On 03/07/2013 04:11 PM, Thierry Reding wrote: + boolen_supply_enabled; This boolean can be dropped. As discussed in a previous thread, the pwm-backlight driver shouldn't need to know about any other uses of the regulator. Sorry for being obstinate - but I'm still not

Re: [PATCH 1/1 v4] pwm_bl: Add support for backlight enable regulator

2013-03-06 Thread Thierry Reding
On Wed, Mar 06, 2013 at 09:17:18AM -0800, Andrew Chew wrote: [...] > diff --git a/drivers/video/backlight/pwm_bl.c > b/drivers/video/backlight/pwm_bl.c > index 069983c..ff98cdd 100644 > --- a/drivers/video/backlight/pwm_bl.c > +++ b/drivers/video/backlight/pwm_bl.c > @@ -20,10 +20,13 @@ > #includ

[PATCH 1/1 v4] pwm_bl: Add support for backlight enable regulator

2013-03-06 Thread Andrew Chew
The backlight enable regulator is specified in the device tree node for backlight. Signed-off-by: Andrew Chew --- Changed the name of the property from en-supply to enable-supply. Made enable-supply a mandatory property. Changed the example in the bindings documentation accordingly. Moved devm