Re: [PATCH 1/1 v6] ARM: imx: Added perf functionality to mmdc driver

2016-09-19 Thread Mark Rutland
Hi, This is generally looking good now. There are just a few issues remaining which I've noted below. On Wed, Sep 14, 2016 at 09:48:20AM -0500, Frank Li wrote: > From: Zhengyu Shen > +static bool mmdc_pmu_group_is_valid(struct perf_event *event) As a general note, you prefix other functions wi

[PATCH 1/1 v6] ARM: imx: Added perf functionality to mmdc driver

2016-09-14 Thread Frank Li
From: Zhengyu Shen MMDC is a multi-mode DDR controller that supports DDR3/DDR3L x16/x32/x64 and LPDDR2 two channel x16/x32 memory types. MMDC is configurable, high performance, and optimized. MMDC is present on i.MX6 Quad and i.MX6 QuadPlus devices, but this driver only supports i.MX6 Quad at the