Re: [PATCH 1/2] [CodingStyle] Add comment to not put spaces before tabs.

2007-05-25 Thread H. Peter Anvin
Kok, Auke wrote: > > ahh yes, I'll incorporate that. > > BTW, would it be possible for cleanfile/cleanpatch to dump warnings to > stderr for lines exceeding 80 characters? I think that would really be > useful... > Should be trivial enough to do, although it probably should be an option.

Re: [PATCH 1/2] [CodingStyle] Add comment to not put spaces before tabs.

2007-05-25 Thread Kok, Auke
H. Peter Anvin wrote: Stefan Richter wrote: Auke Kok wrote: +Don't put spaces before tabs or mix them. Make it "Don't put spaces before tabs." We do mix them if we combine tabs for indentation with spaces for alignment. It would probably be good to add a pointer to the cleanfile/cleanpatch

Re: [PATCH 1/2] [CodingStyle] Add comment to not put spaces before tabs.

2007-05-25 Thread H. Peter Anvin
Stefan Richter wrote: > Auke Kok wrote: >> +Don't put spaces before tabs or mix them. > > Make it "Don't put spaces before tabs." > > We do mix them if we combine tabs for indentation with spaces for alignment. It would probably be good to add a pointer to the cleanfile/cleanpatch scripts here,

Re: [PATCH 1/2] [CodingStyle] Add comment to not put spaces before tabs.

2007-05-25 Thread Stefan Richter
Auke Kok wrote: > +Don't put spaces before tabs or mix them. Make it "Don't put spaces before tabs." We do mix them if we combine tabs for indentation with spaces for alignment. -- Stefan Richter -=-=-=== -=-= ==--= http://arcgraph.de/sr/ - To unsubscribe from this list: send the line

[PATCH 1/2] [CodingStyle] Add comment to not put spaces before tabs.

2007-05-25 Thread Auke Kok
Mixed space/tab indentation is wrong. Ironically this is what the coding style document actually shows ;) Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- Documentation/CodingStyle |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/Documentation/CodingStyle

[PATCH 1/2] [CodingStyle] Add comment to not put spaces before tabs.

2007-05-25 Thread Auke Kok
Mixed space/tab indentation is wrong. Ironically this is what the coding style document actually shows ;) Signed-off-by: Auke Kok [EMAIL PROTECTED] --- Documentation/CodingStyle |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/Documentation/CodingStyle

Re: [PATCH 1/2] [CodingStyle] Add comment to not put spaces before tabs.

2007-05-25 Thread Stefan Richter
Auke Kok wrote: +Don't put spaces before tabs or mix them. Make it Don't put spaces before tabs. We do mix them if we combine tabs for indentation with spaces for alignment. -- Stefan Richter -=-=-=== -=-= ==--= http://arcgraph.de/sr/ - To unsubscribe from this list: send the line

Re: [PATCH 1/2] [CodingStyle] Add comment to not put spaces before tabs.

2007-05-25 Thread H. Peter Anvin
Stefan Richter wrote: Auke Kok wrote: +Don't put spaces before tabs or mix them. Make it Don't put spaces before tabs. We do mix them if we combine tabs for indentation with spaces for alignment. It would probably be good to add a pointer to the cleanfile/cleanpatch scripts here, too.

Re: [PATCH 1/2] [CodingStyle] Add comment to not put spaces before tabs.

2007-05-25 Thread Kok, Auke
H. Peter Anvin wrote: Stefan Richter wrote: Auke Kok wrote: +Don't put spaces before tabs or mix them. Make it Don't put spaces before tabs. We do mix them if we combine tabs for indentation with spaces for alignment. It would probably be good to add a pointer to the cleanfile/cleanpatch

Re: [PATCH 1/2] [CodingStyle] Add comment to not put spaces before tabs.

2007-05-25 Thread H. Peter Anvin
Kok, Auke wrote: ahh yes, I'll incorporate that. BTW, would it be possible for cleanfile/cleanpatch to dump warnings to stderr for lines exceeding 80 characters? I think that would really be useful... Should be trivial enough to do, although it probably should be an option.