Re: [PATCH 1/2] [x86] arch/x86/kernel/signal_32.c: replace !likely(x) by likely(!x)

2008-02-17 Thread Ingo Molnar
* Roel Kluin <[EMAIL PROTECTED]> wrote: > - if (on_sig_stack(sp) && !likely(on_sig_stack(sp - frame_size))) > + if (on_sig_stack(sp) && unlikely(!on_sig_stack(sp - frame_size))) hm, what's the purpose of this change? Ingo -- To unsubscribe from this list: send the line

Re: [PATCH 1/2] [x86] arch/x86/kernel/signal_32.c: replace !likely(x) by likely(!x)

2008-02-17 Thread Ingo Molnar
* Roel Kluin [EMAIL PROTECTED] wrote: - if (on_sig_stack(sp) !likely(on_sig_stack(sp - frame_size))) + if (on_sig_stack(sp) unlikely(!on_sig_stack(sp - frame_size))) hm, what's the purpose of this change? Ingo -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 1/2] [x86] arch/x86/kernel/signal_32.c: replace !likely(x) by likely(!x)

2008-02-16 Thread Roel Kluin
Roel Kluin wrote: > Roel Kluin wrote: >> Replace !likely(x) by likely(!x) > sorry, please ignore this patch The patch below shouldn't change semantics. --- replace !likely(x) by unlikely(!x) Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/arch/x86/kernel/signal_32.c

Re: [PATCH 1/2] [x86] arch/x86/kernel/signal_32.c: replace !likely(x) by likely(!x)

2008-02-16 Thread Roel Kluin
Roel Kluin wrote: > Replace !likely(x) by likely(!x) > > Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> > --- > diff --git a/arch/x86/kernel/signal_32.c b/arch/x86/kernel/signal_32.c > index caee1f0..335872f 100644 > --- a/arch/x86/kernel/signal_32.c > +++ b/arch/x86/kernel/signal_32.c > @@ -303,7

[PATCH 1/2] [x86] arch/x86/kernel/signal_32.c: replace !likely(x) by likely(!x)

2008-02-16 Thread Roel Kluin
Replace !likely(x) by likely(!x) Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/arch/x86/kernel/signal_32.c b/arch/x86/kernel/signal_32.c index caee1f0..335872f 100644 --- a/arch/x86/kernel/signal_32.c +++ b/arch/x86/kernel/signal_32.c @@ -303,7 +303,7 @@ get_sigframe(struct

[PATCH 1/2] [x86] arch/x86/kernel/signal_32.c: replace !likely(x) by likely(!x)

2008-02-16 Thread Roel Kluin
Replace !likely(x) by likely(!x) Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/arch/x86/kernel/signal_32.c b/arch/x86/kernel/signal_32.c index caee1f0..335872f 100644 --- a/arch/x86/kernel/signal_32.c +++ b/arch/x86/kernel/signal_32.c @@ -303,7 +303,7 @@ get_sigframe(struct

Re: [PATCH 1/2] [x86] arch/x86/kernel/signal_32.c: replace !likely(x) by likely(!x)

2008-02-16 Thread Roel Kluin
Roel Kluin wrote: Replace !likely(x) by likely(!x) Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/arch/x86/kernel/signal_32.c b/arch/x86/kernel/signal_32.c index caee1f0..335872f 100644 --- a/arch/x86/kernel/signal_32.c +++ b/arch/x86/kernel/signal_32.c @@ -303,7 +303,7 @@

Re: [PATCH 1/2] [x86] arch/x86/kernel/signal_32.c: replace !likely(x) by likely(!x)

2008-02-16 Thread Roel Kluin
Roel Kluin wrote: Roel Kluin wrote: Replace !likely(x) by likely(!x) sorry, please ignore this patch The patch below shouldn't change semantics. --- replace !likely(x) by unlikely(!x) Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/arch/x86/kernel/signal_32.c