Re: [PATCH 1/2] ARC: U-boot: check arguments paranoidly

2019-02-12 Thread Vineet Gupta
On 2/12/19 9:25 AM, Eugeniy Paltsev wrote: >> This is technically changing the ABI - I think we don't need to enforce this >> - >> keep ignoring this > I think it's better to add this check: > * This check doesn't break backward compatibility. ARC U-boot pass zero to r1 >from the beginnings,

Re: [PATCH 1/2] ARC: U-boot: check arguments paranoidly

2019-02-12 Thread Eugeniy Paltsev
On Tue, 2019-02-12 at 16:45 +, Vineet Gupta wrote: > On 2/12/19 7:39 AM, Eugeniy Paltsev wrote: > > Handle U-boot arguments paranoidly: > > * don't allow to pass unknown tag. > > * try to use external device tree blob only if corresponding tag > >(TAG_DTB) is set. > > * check that magic

Re: [PATCH 1/2] ARC: U-boot: check arguments paranoidly

2019-02-12 Thread Vineet Gupta
On 2/12/19 7:39 AM, Eugeniy Paltsev wrote: > Handle U-boot arguments paranoidly: > * don't allow to pass unknown tag. > * try to use external device tree blob only if corresponding tag >(TAG_DTB) is set. > * check that magic number is correct. > * don't check uboot_tag if kernel build with

Re: [PATCH 1/2] ARC: U-boot: check arguments paranoidly

2019-02-12 Thread Vineet Gupta
On 2/12/19 8:39 AM, LABBE Corentin wrote: >> While I'm at it refactor U-boot arguments handling code. >> > Hello > > I have tried to test this serie, but this patch does not apply anymore on > current next tree. > It conflicts with "ARC: boot: robustify u-boot arg referencing". I was carrying

Re: [PATCH 1/2] ARC: U-boot: check arguments paranoidly

2019-02-12 Thread LABBE Corentin
On Tue, Feb 12, 2019 at 06:39:31PM +0300, Eugeniy Paltsev wrote: > Handle U-boot arguments paranoidly: > * don't allow to pass unknown tag. > * try to use external device tree blob only if corresponding tag >(TAG_DTB) is set. > * check that magic number is correct. > * don't check

[PATCH 1/2] ARC: U-boot: check arguments paranoidly

2019-02-12 Thread Eugeniy Paltsev
Handle U-boot arguments paranoidly: * don't allow to pass unknown tag. * try to use external device tree blob only if corresponding tag (TAG_DTB) is set. * check that magic number is correct. * don't check uboot_tag if kernel build with no ARC_UBOOT_SUPPORT. NOTE: If U-boot args are