Re: [PATCH 1/2] ASoC: audio-graph: Export graph_remove() function

On 2/4/2021 4:03 AM, Kuninori Morimoto wrote: External email: Use caution opening links or attachments Hi +int graph_remove(struct platform_device *pdev); I think this needs better namespacing if it's going to be exported. audio_graph_remove() can be a better choice? Yeah, that looks re

Re: [PATCH 1/2] ASoC: audio-graph: Export graph_remove() function

On 2/4/2021 4:01 AM, Kuninori Morimoto wrote: Audio graph based sound card drivers can call graph_remove() function for cleanups during driver removal. To facilitate this export above mentioned function. Signed-off-by: Sameer Pujar Cc: Kuninori Morimoto (snip) -static int graph_remove(str

Re: [PATCH 1/2] ASoC: audio-graph: Export graph_remove() function

Hi > > > > +int graph_remove(struct platform_device *pdev); > > > > I think this needs better namespacing if it's going to be exported. > > > audio_graph_remove() can be a better choice? > > Yeah, that looks reasonable. Nice naming I think. In such case, update also graph_parse_of() is nice

Re: [PATCH 1/2] ASoC: audio-graph: Export graph_remove() function

Hi Sameer > Audio graph based sound card drivers can call graph_remove() function > for cleanups during driver removal. To facilitate this export above > mentioned function. > > Signed-off-by: Sameer Pujar > Cc: Kuninori Morimoto (snip) > -static int graph_remove(struct platform_device *pdev)

Re: Re: [PATCH 1/2] ASoC: audio-graph: Export graph_remove() function

On Wed, Feb 03, 2021 at 10:09:01PM +0530, Sameer Pujar wrote: > On 2/3/2021 9:49 PM, Mark Brown wrote: > > On Wed, Feb 03, 2021 at 09:39:34PM +0530, Sameer Pujar wrote: > > > +int graph_remove(struct platform_device *pdev); > > I think this needs better namespacing if it's going to be exported.

Re: Re: [PATCH 1/2] ASoC: audio-graph: Export graph_remove() function

On 2/3/2021 9:49 PM, Mark Brown wrote: On Wed, Feb 03, 2021 at 09:39:34PM +0530, Sameer Pujar wrote: +int graph_remove(struct platform_device *pdev); I think this needs better namespacing if it's going to be exported. audio_graph_remove() can be a better choice?

Re: [PATCH 1/2] ASoC: audio-graph: Export graph_remove() function

On Wed, Feb 03, 2021 at 09:39:34PM +0530, Sameer Pujar wrote: > +int graph_remove(struct platform_device *pdev); I think this needs better namespacing if it's going to be exported. signature.asc Description: PGP signature

[PATCH 1/2] ASoC: audio-graph: Export graph_remove() function

Audio graph based sound card drivers can call graph_remove() function for cleanups during driver removal. To facilitate this export above mentioned function. Signed-off-by: Sameer Pujar Cc: Kuninori Morimoto --- include/sound/graph_card.h | 2 ++ sound/soc/generic/audio-graph-card.c |