RE: [PATCH 1/2] ASoC: da7213: Delete an error message for a failed memory allocation in da7213_fw_to_pdata()

2017-11-24 Thread Adam Thomson
On 24 November 2017 11:33, Julia Lawall wrote: > On Fri, 24 Nov 2017, Adam Thomson wrote: > > > On 23 November 2017 17:33, SF Markus Elfring wrote: > > > > > From: Markus Elfring > > > Date: Thu, 23 Nov 2017 17:56:54 +0100 > > > > > > Omit an extra message for a memory allocation failure in this

RE: [PATCH 1/2] ASoC: da7213: Delete an error message for a failed memory allocation in da7213_fw_to_pdata()

2017-11-24 Thread Julia Lawall
On Fri, 24 Nov 2017, Adam Thomson wrote: > On 23 November 2017 17:33, SF Markus Elfring wrote: > > > From: Markus Elfring > > Date: Thu, 23 Nov 2017 17:56:54 +0100 > > > > Omit an extra message for a memory allocation failure in this function. > > I'm not sure this is an extra message. We don't

RE: [PATCH 1/2] ASoC: da7213: Delete an error message for a failed memory allocation in da7213_fw_to_pdata()

2017-11-24 Thread Adam Thomson
On 23 November 2017 17:33, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 23 Nov 2017 17:56:54 +0100 > > Omit an extra message for a memory allocation failure in this function. I'm not sure this is an extra message. We don't return -ENOMEM as a result of this operation and probe w

[PATCH 1/2] ASoC: da7213: Delete an error message for a failed memory allocation in da7213_fw_to_pdata()

2017-11-23 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 23 Nov 2017 17:56:54 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- sound/soc/codecs/da7213.c | 4 +--- 1 file changed, 1 insertion(+), 3