Re: [PATCH 1/2] ASoC: sirf: Add audio usp interface driver

2014-07-01 Thread Mark Brown
On Tue, Jul 01, 2014 at 10:18:53AM +0800, Rongjun Ying wrote: A few *really* trivial things below, otherwise this looks good: > + if (usp->daifmt_format == SND_SOC_DAIFMT_I2S) > + regmap_update_bits(usp->regmap, USP_RX_FRAME_CTRL, > + USP_I2S_SYNC_CHG, USP_I2S_

[PATCH 1/2] ASoC: sirf: Add audio usp interface driver

2014-06-30 Thread Rongjun Ying
This patch adds ASoC support for SiRF SoCs USP interface. Features include: 1. Only support slave mode. 2. Support I2S and DSP_A mode. 3. Support S16_LE, S24_LE and S24_3LE formats. 4. Support stereo and mono mode. 5. The biggest Support is 192Khz sample rate. Signed-off-by: Rongjun Ying --- sou