Re: [PATCH 1/2] ASoC: tlv320adcx140: Avoid accessing invalid gpio_reset

2020-09-09 Thread Mark Brown
On Wed, Sep 09, 2020 at 12:06:45PM +0200, Camel Guo wrote: > On 9/8/20 7:20 PM, Mark Brown wrote: > > Applied to > > https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next > I think it is "ASoC: tlv320adcx140: Wake up codec before register setting" > that is applied to for ne

Re: [PATCH 1/2] ASoC: tlv320adcx140: Avoid accessing invalid gpio_reset

2020-09-09 Thread Camel Guo
Hi Peter, Thanks for your comment. I will make a new one like what you said. On 9/8/20 2:03 PM, Peter Ujfalusi wrote: Hi, On 08/09/2020 14.59, Peter Ujfalusi wrote: On 08/09/2020 11.35, Camel Guo wrote: From: Camel Guo When gpio_reset is not well defined in devicetree, the adcx140->gpio_

Re: [PATCH 1/2] ASoC: tlv320adcx140: Avoid accessing invalid gpio_reset

2020-09-09 Thread Camel Guo
Mark On 9/8/20 7:20 PM, Mark Brown wrote: On Tue, 8 Sep 2020 10:35:20 +0200, Camel Guo wrote: When gpio_reset is not well defined in devicetree, the adcx140->gpio_reset is an error code instead of NULL. In this case, adcx140->gpio_reset should not be used by adcx140_reset. This commit sets it N

Re: [PATCH 1/2] ASoC: tlv320adcx140: Avoid accessing invalid gpio_reset

2020-09-08 Thread Peter Ujfalusi
On 08/09/2020 11.35, Camel Guo wrote: > From: Camel Guo > > When gpio_reset is not well defined in devicetree, the > adcx140->gpio_reset is an error code instead of NULL. In this case, > adcx140->gpio_reset should not be used by adcx140_reset. This commit > sets it NULL to avoid accessing an i

Re: [PATCH 1/2] ASoC: tlv320adcx140: Avoid accessing invalid gpio_reset

2020-09-08 Thread Peter Ujfalusi
Hi, On 08/09/2020 14.59, Peter Ujfalusi wrote: > > > On 08/09/2020 11.35, Camel Guo wrote: >> From: Camel Guo >> >> When gpio_reset is not well defined in devicetree, the >> adcx140->gpio_reset is an error code instead of NULL. In this case, >> adcx140->gpio_reset should not be used by adcx140_

Re: [PATCH 1/2] ASoC: tlv320adcx140: Avoid accessing invalid gpio_reset

2020-09-08 Thread Dan Murphy

Re: [PATCH 1/2] ASoC: tlv320adcx140: Avoid accessing invalid gpio_reset

2020-09-08 Thread Mark Brown
On Tue, 8 Sep 2020 10:35:20 +0200, Camel Guo wrote: > When gpio_reset is not well defined in devicetree, the > adcx140->gpio_reset is an error code instead of NULL. In this case, > adcx140->gpio_reset should not be used by adcx140_reset. This commit > sets it NULL to avoid accessing an invalid vari

[PATCH 1/2] ASoC: tlv320adcx140: Avoid accessing invalid gpio_reset

2020-09-08 Thread Camel Guo
From: Camel Guo When gpio_reset is not well defined in devicetree, the adcx140->gpio_reset is an error code instead of NULL. In this case, adcx140->gpio_reset should not be used by adcx140_reset. This commit sets it NULL to avoid accessing an invalid variable. Signed-off-by: Camel Guo --- soun