Re: [PATCH 1/2] CFS CGroup: Code cleanup

2007-10-23 Thread Ingo Molnar
* Srivatsa Vaddagiri <[EMAIL PROTECTED]> wrote: > On Tue, Oct 23, 2007 at 07:32:27PM -0700, Paul Menage wrote: > > Clean up some CFS CGroup code > > > > - replace "cont" with "cgrp" in a few places in the CFS cgroup code, > > - use write_uint rather than write for cpu.shares write function > >

Re: [PATCH 1/2] CFS CGroup: Code cleanup

2007-10-23 Thread Srivatsa Vaddagiri
On Tue, Oct 23, 2007 at 07:32:27PM -0700, Paul Menage wrote: > Clean up some CFS CGroup code > > - replace "cont" with "cgrp" in a few places in the CFS cgroup code, > - use write_uint rather than write for cpu.shares write function > > Signed-off-by: Paul Menage <[EMAIL PROTECTED]> Acked-by :

[PATCH 1/2] CFS CGroup: Code cleanup

2007-10-23 Thread Paul Menage
Clean up some CFS CGroup code - replace "cont" with "cgrp" in a few places in the CFS cgroup code, - use write_uint rather than write for cpu.shares write function Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- This is a resend of yesterday's mail with the same subject; the final hunk wa

Re: [PATCH 1/2] CFS CGroup: Code cleanup

2007-10-23 Thread Paul Menage
On 10/22/07, Paul Menage <[EMAIL PROTECTED]> wrote: > On 10/22/07, Srivatsa Vaddagiri <[EMAIL PROTECTED]> wrote: > > > > Minor nit: From pov of making this patch series git bisect safe, shouldn't > > we > > be registering a write_uint() handler in this patch as well? > > > > Yes, we should. Sigh.

Re: [PATCH 1/2] CFS CGroup: Code cleanup

2007-10-22 Thread Paul Menage
On 10/22/07, Srivatsa Vaddagiri <[EMAIL PROTECTED]> wrote: > > Minor nit: From pov of making this patch series git bisect safe, shouldn't we > be registering a write_uint() handler in this patch as well? > Yes, we should. Sigh. I originally had the cleanup and the new reporting interface in the sa

Re: [PATCH 1/2] CFS CGroup: Code cleanup

2007-10-22 Thread Srivatsa Vaddagiri
On Mon, Oct 22, 2007 at 05:49:20PM -0700, Paul Menage wrote: > Clean up some CFS CGroup code > > - replace "cont" with "cgrp" in a few places in the CFS cgroup code, This change looks good to me. Thanks for doing it. > - use write_uint rather than write for cpu.shares write function Minor nit:

[PATCH 1/2] CFS CGroup: Code cleanup

2007-10-22 Thread Paul Menage
Clean up some CFS CGroup code - replace "cont" with "cgrp" in a few places in the CFS cgroup code, - use write_uint rather than write for cpu.shares write function Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- kernel/sched.c | 51 +-- 1 fi