Re: [PATCH 1/2] Fix cg_read_strcmp()

2018-09-07 Thread Shuah Khan
On 09/07/2018 12:28 PM, Jay Kamat wrote: > > Shuah Khan writes: > >> On 09/07/2018 10:49 AM, jgka...@fb.com wrote: >>> From: Jay Kamat >>> >>> Fix a couple issues with cg_read_strcmp(), to improve correctness of >>> cgroup tests >>> - Fix cg_read_strcmp() always returning 0 for empty "needle"

Re: [PATCH 1/2] Fix cg_read_strcmp()

2018-09-07 Thread Shuah Khan
On 09/07/2018 12:28 PM, Jay Kamat wrote: > > Shuah Khan writes: > >> On 09/07/2018 10:49 AM, jgka...@fb.com wrote: >>> From: Jay Kamat >>> >>> Fix a couple issues with cg_read_strcmp(), to improve correctness of >>> cgroup tests >>> - Fix cg_read_strcmp() always returning 0 for empty "needle"

Re: [PATCH 1/2] Fix cg_read_strcmp()

2018-09-07 Thread Jay Kamat
Shuah Khan writes: > On 09/07/2018 10:49 AM, jgka...@fb.com wrote: >> From: Jay Kamat >> >> Fix a couple issues with cg_read_strcmp(), to improve correctness of >> cgroup tests >> - Fix cg_read_strcmp() always returning 0 for empty "needle" strings >> - Fix a memory leak in cg_read_strcmp() >>

Re: [PATCH 1/2] Fix cg_read_strcmp()

2018-09-07 Thread Jay Kamat
Shuah Khan writes: > On 09/07/2018 10:49 AM, jgka...@fb.com wrote: >> From: Jay Kamat >> >> Fix a couple issues with cg_read_strcmp(), to improve correctness of >> cgroup tests >> - Fix cg_read_strcmp() always returning 0 for empty "needle" strings >> - Fix a memory leak in cg_read_strcmp() >>

Re: [PATCH 1/2] Fix cg_read_strcmp()

2018-09-07 Thread Shuah Khan
On 09/07/2018 10:49 AM, jgka...@fb.com wrote: > From: Jay Kamat > > Fix a couple issues with cg_read_strcmp(), to improve correctness of > cgroup tests > - Fix cg_read_strcmp() always returning 0 for empty "needle" strings > - Fix a memory leak in cg_read_strcmp() > > Fixes: 84092dbcf901

Re: [PATCH 1/2] Fix cg_read_strcmp()

2018-09-07 Thread Shuah Khan
On 09/07/2018 10:49 AM, jgka...@fb.com wrote: > From: Jay Kamat > > Fix a couple issues with cg_read_strcmp(), to improve correctness of > cgroup tests > - Fix cg_read_strcmp() always returning 0 for empty "needle" strings > - Fix a memory leak in cg_read_strcmp() > > Fixes: 84092dbcf901

Re: [PATCH 1/2] Fix cg_read_strcmp()

2018-09-07 Thread Roman Gushchin
On Fri, Sep 07, 2018 at 09:49:23AM -0700, jgka...@fb.com wrote: > From: Jay Kamat > > Fix a couple issues with cg_read_strcmp(), to improve correctness of > cgroup tests > - Fix cg_read_strcmp() always returning 0 for empty "needle" strings > - Fix a memory leak in cg_read_strcmp() > > Fixes:

Re: [PATCH 1/2] Fix cg_read_strcmp()

2018-09-07 Thread Roman Gushchin
On Fri, Sep 07, 2018 at 09:49:23AM -0700, jgka...@fb.com wrote: > From: Jay Kamat > > Fix a couple issues with cg_read_strcmp(), to improve correctness of > cgroup tests > - Fix cg_read_strcmp() always returning 0 for empty "needle" strings > - Fix a memory leak in cg_read_strcmp() > > Fixes:

[PATCH 1/2] Fix cg_read_strcmp()

2018-09-07 Thread jgkamat
From: Jay Kamat Fix a couple issues with cg_read_strcmp(), to improve correctness of cgroup tests - Fix cg_read_strcmp() always returning 0 for empty "needle" strings - Fix a memory leak in cg_read_strcmp() Fixes: 84092dbcf901 ("selftests: cgroup: add memory controller self-tests")

[PATCH 1/2] Fix cg_read_strcmp()

2018-09-07 Thread jgkamat
From: Jay Kamat Fix a couple issues with cg_read_strcmp(), to improve correctness of cgroup tests - Fix cg_read_strcmp() always returning 0 for empty "needle" strings - Fix a memory leak in cg_read_strcmp() Fixes: 84092dbcf901 ("selftests: cgroup: add memory controller self-tests")

Re: [PATCH 1/2] Fix cg_read_strcmp()

2018-09-05 Thread Shuah Khan
Hi Jay, Thanks for the patch. Couple of comments below. On 09/04/2018 07:08 PM, jgka...@fb.com wrote: > From: Jay Kamat > > Fix a couple issues with cg_read_strcmp(), to improve correctness of > cgroup tests > - Fix cg_read_strcmp() always returning 0 for empty "needle" strings > - Fix a

Re: [PATCH 1/2] Fix cg_read_strcmp()

2018-09-05 Thread Shuah Khan
Hi Jay, Thanks for the patch. Couple of comments below. On 09/04/2018 07:08 PM, jgka...@fb.com wrote: > From: Jay Kamat > > Fix a couple issues with cg_read_strcmp(), to improve correctness of > cgroup tests > - Fix cg_read_strcmp() always returning 0 for empty "needle" strings > - Fix a

[PATCH 1/2] Fix cg_read_strcmp()

2018-09-04 Thread jgkamat
From: Jay Kamat Fix a couple issues with cg_read_strcmp(), to improve correctness of cgroup tests - Fix cg_read_strcmp() always returning 0 for empty "needle" strings - Fix a memory leak in cg_read_strcmp() Fixes: 84092dbcf901 ("selftests: cgroup: add memory controller self-tests")

[PATCH 1/2] Fix cg_read_strcmp()

2018-09-04 Thread jgkamat
From: Jay Kamat Fix a couple issues with cg_read_strcmp(), to improve correctness of cgroup tests - Fix cg_read_strcmp() always returning 0 for empty "needle" strings - Fix a memory leak in cg_read_strcmp() Fixes: 84092dbcf901 ("selftests: cgroup: add memory controller self-tests")