Re: [PATCH 1/2] HID: do not call hid_set_drvdata(hdev, NULL) in drivers

2019-08-22 Thread Benjamin Tissoires
On Tue, Aug 13, 2019 at 7:54 AM Bruno Prémont wrote: > > On Mon, 12 Aug 2019 18:27:39 +0200 Benjamin Tissoires wrote: > > This is a common pattern in the HID drivers to reset the drvdata. Some > > do it properly, some do it only in case of failure. > > > > But, this is actually already handled by

Re: [PATCH 1/2] HID: do not call hid_set_drvdata(hdev, NULL) in drivers

2019-08-12 Thread Bruno Prémont
On Mon, 12 Aug 2019 18:27:39 +0200 Benjamin Tissoires wrote: > This is a common pattern in the HID drivers to reset the drvdata. Some > do it properly, some do it only in case of failure. > > But, this is actually already handled by driver core, so there is no need > to do it manually. > > Signed

Re: [PATCH 1/2] HID: do not call hid_set_drvdata(hdev, NULL) in drivers

2019-08-12 Thread Srinivas Pandruvada
On Mon, 2019-08-12 at 18:27 +0200, Benjamin Tissoires wrote: > This is a common pattern in the HID drivers to reset the drvdata. > Some > do it properly, some do it only in case of failure. > > But, this is actually already handled by driver core, so there is no > need > to do it manually. > > Si

[PATCH 1/2] HID: do not call hid_set_drvdata(hdev, NULL) in drivers

2019-08-12 Thread Benjamin Tissoires
This is a common pattern in the HID drivers to reset the drvdata. Some do it properly, some do it only in case of failure. But, this is actually already handled by driver core, so there is no need to do it manually. Signed-off-by: Benjamin Tissoires --- drivers/hid/hid-cougar.c | 6 ++