Re: [PATCH 1/2] INPUT/HID: add touch support for SiS touch driver

2015-02-16 Thread Oliver Neukum
On Thu, 2015-02-12 at 14:07 +0800, 曾婷葳 (tammy_tseng) wrote: > Hi, > > I've checked the coding style and modified the i2c and hid touch driver for > sis touch controller. > Please help review them. > Thanks a lot. Sorry, I accidentally reviewed the old version first. > > Tammy > - > Here

Re: [PATCH 1/2] INPUT/HID: add touch support for SiS touch driver

2015-02-16 Thread Oliver Neukum
On Fri, 2015-01-16 at 18:59 +0800, 曾婷葳 (tammy_tseng) wrote: > Hey, Oliver > > On Mon, Jan 12, 2015 at 7:50 PM, Oliver Neukum wrote: > On Mon, 2015-01-12 at 18:53 +0800, 曾婷葳 (tammy_tseng) wrote: > > > (Skip the code diff...) > > > > Again macros for endianness > > > > And the driver has a great

Re: [PATCH 1/2] INPUT/HID: add touch support for SiS touch driver

2015-02-16 Thread Oliver Neukum
On Fri, 2015-01-16 at 18:59 +0800, 曾婷葳 (tammy_tseng) wrote: Hey, Oliver On Mon, Jan 12, 2015 at 7:50 PM, Oliver Neukum oneu...@suse.de wrote: On Mon, 2015-01-12 at 18:53 +0800, 曾婷葳 (tammy_tseng) wrote: (Skip the code diff...) Again macros for endianness And the driver has a great

Re: [PATCH 1/2] INPUT/HID: add touch support for SiS touch driver

2015-02-16 Thread Oliver Neukum
On Thu, 2015-02-12 at 14:07 +0800, 曾婷葳 (tammy_tseng) wrote: Hi, I've checked the coding style and modified the i2c and hid touch driver for sis touch controller. Please help review them. Thanks a lot. Sorry, I accidentally reviewed the old version first. Tammy - Here is the

Re: [PATCH 1/2] INPUT/HID: add touch support for SiS touch driver

2015-02-11 Thread Dmitry Torokhov
Hi Tammy, On Thu, Feb 12, 2015 at 02:07:21PM +0800, 曾婷葳 (tammy_tseng) wrote: > Hi, > > I've checked the coding style and modified the i2c and hid touch driver for > sis touch controller. > Please help review them. > Thanks a lot. This was again sent in base64, with DOS file endings... > >

RE: [PATCH 1/2] INPUT/HID: add touch support for SiS touch driver

2015-02-11 Thread tammy_tseng
Hi, I've checked the coding style and modified the i2c and hid touch driver for sis touch controller. Please help review them. Thanks a lot. Tammy - Here is the sis i2c driver in input: linux-3.18.5/drivers/input/touchscreen/Kconfig |7 +

Re: [PATCH 1/2] INPUT/HID: add touch support for SiS touch driver

2015-02-11 Thread Dmitry Torokhov
Hi Tammy, On Thu, Feb 12, 2015 at 02:07:21PM +0800, 曾婷葳 (tammy_tseng) wrote: Hi, I've checked the coding style and modified the i2c and hid touch driver for sis touch controller. Please help review them. Thanks a lot. This was again sent in base64, with DOS file endings... Tammy

RE: [PATCH 1/2] INPUT/HID: add touch support for SiS touch driver

2015-02-11 Thread tammy_tseng
Hi, I've checked the coding style and modified the i2c and hid touch driver for sis touch controller. Please help review them. Thanks a lot. Tammy - Here is the sis i2c driver in input: linux-3.18.5/drivers/input/touchscreen/Kconfig |7 +

Re: [PATCH 1/2] INPUT/HID: add touch support for SiS touch driver

2015-01-16 Thread Dmitry Torokhov
On Fri, Jan 16, 2015 at 5:11 AM, Oliver Neukum wrote: > On Fri, 2015-01-16 at 18:59 +0800, 曾婷葳 (tammy_tseng) wrote: >> Hey, Oliver >> >> On Mon, Jan 12, 2015 at 7:50 PM, Oliver Neukum wrote: >> On Mon, 2015-01-12 at 18:53 +0800, 曾婷葳 (tammy_tseng) wrote: >> > > (Skip the code diff...) >> > >> >

Re: [PATCH 1/2] INPUT/HID: add touch support for SiS touch driver

2015-01-16 Thread Oliver Neukum
On Fri, 2015-01-16 at 18:59 +0800, 曾婷葳 (tammy_tseng) wrote: > Hey, Oliver > > On Mon, Jan 12, 2015 at 7:50 PM, Oliver Neukum wrote: > On Mon, 2015-01-12 at 18:53 +0800, 曾婷葳 (tammy_tseng) wrote: > > > (Skip the code diff...) > > > > Again macros for endianness > > > > And the driver has a great

RE: [PATCH 1/2] INPUT/HID: add touch support for SiS touch driver

2015-01-16 Thread tammy_tseng
Hey, Oliver On Mon, Jan 12, 2015 at 7:50 PM, Oliver Neukum wrote: On Mon, 2015-01-12 at 18:53 +0800, 曾婷葳 (tammy_tseng) wrote: > > (Skip the code diff...) > > Again macros for endianness > > And the driver has a great number of conditional compilations are they > really needed? The driver as

RE: [PATCH 1/2] INPUT/HID: add touch support for SiS touch driver

2015-01-16 Thread tammy_tseng
Hey, Oliver On Mon, Jan 12, 2015 at 7:50 PM, Oliver Neukum wrote: On Mon, 2015-01-12 at 18:53 +0800, 曾婷葳 (tammy_tseng) wrote: > > (Skip the code diff...) > > Again macros for endianness > > And the driver has a great number of conditional compilations are they > really needed? The driver as

Re: [PATCH 1/2] INPUT/HID: add touch support for SiS touch driver

2015-01-16 Thread Dmitry Torokhov
On Fri, Jan 16, 2015 at 5:11 AM, Oliver Neukum oneu...@suse.de wrote: On Fri, 2015-01-16 at 18:59 +0800, 曾婷葳 (tammy_tseng) wrote: Hey, Oliver On Mon, Jan 12, 2015 at 7:50 PM, Oliver Neukum oneu...@suse.de wrote: On Mon, 2015-01-12 at 18:53 +0800, 曾婷葳 (tammy_tseng) wrote: (Skip the code

RE: [PATCH 1/2] INPUT/HID: add touch support for SiS touch driver

2015-01-16 Thread tammy_tseng
Hey, Oliver On Mon, Jan 12, 2015 at 7:50 PM, Oliver Neukum oneu...@suse.de wrote: On Mon, 2015-01-12 at 18:53 +0800, 曾婷葳 (tammy_tseng) wrote: (Skip the code diff...) Again macros for endianness And the driver has a great number of conditional compilations are they really needed? The

RE: [PATCH 1/2] INPUT/HID: add touch support for SiS touch driver

2015-01-16 Thread tammy_tseng
Hey, Oliver On Mon, Jan 12, 2015 at 7:50 PM, Oliver Neukum oneu...@suse.de wrote: On Mon, 2015-01-12 at 18:53 +0800, 曾婷葳 (tammy_tseng) wrote: (Skip the code diff...) Again macros for endianness And the driver has a great number of conditional compilations are they really needed? The

Re: [PATCH 1/2] INPUT/HID: add touch support for SiS touch driver

2015-01-16 Thread Oliver Neukum
On Fri, 2015-01-16 at 18:59 +0800, 曾婷葳 (tammy_tseng) wrote: Hey, Oliver On Mon, Jan 12, 2015 at 7:50 PM, Oliver Neukum oneu...@suse.de wrote: On Mon, 2015-01-12 at 18:53 +0800, 曾婷葳 (tammy_tseng) wrote: (Skip the code diff...) Again macros for endianness And the driver has a great

Re: [PATCH 1/2] INPUT/HID: add touch support for SiS touch driver

2015-01-12 Thread Oliver Neukum
On Mon, 2015-01-12 at 18:53 +0800, 曾婷葳 (tammy_tseng) wrote: > Hi, > This package of patch is to add support for multitouch behavior for SiS touch > products. > The patch of SiS i2c multitouch driver is in input/touchscreen. > > Signed-off-by: Tammy Tseng > > --- > diff --git

RE: [PATCH 1/2] INPUT/HID: add touch support for SiS touch driver

2015-01-12 Thread tammy_tseng
Hi, This package of patch is to add support for multitouch behavior for SiS touch products. The patch of SiS i2c multitouch driver is in input/touchscreen. Signed-off-by: Tammy Tseng --- diff --git a/linux-3.18.1/drivers/input/touchscreen/Kconfig

RE: [PATCH 1/2] INPUT/HID: add touch support for SiS touch driver

2015-01-12 Thread tammy_tseng
Hi, This package of patch is to add support for multitouch behavior for SiS touch products. The patch of SiS i2c multitouch driver is in input/touchscreen. Signed-off-by: Tammy Tseng tammy_ts...@sis.com --- diff --git a/linux-3.18.1/drivers/input/touchscreen/Kconfig

Re: [PATCH 1/2] INPUT/HID: add touch support for SiS touch driver

2015-01-12 Thread Oliver Neukum
On Mon, 2015-01-12 at 18:53 +0800, 曾婷葳 (tammy_tseng) wrote: Hi, This package of patch is to add support for multitouch behavior for SiS touch products. The patch of SiS i2c multitouch driver is in input/touchscreen. Signed-off-by: Tammy Tseng tammy_ts...@sis.com --- diff --git

[PATCH 1/2] INPUT/HID: add touch support for SiS touch driver

2015-01-09 Thread tammy_tseng
Hi, This package of patch is to add support for multitouch behavior for SiS touch products. The patch of SiS i2c multitouch driver is in input/touchscreen. Signed-off-by: Tammy Tseng -- diff --git a/linux-3.18.1/drivers/input/touchscreen/Kconfig

[PATCH 1/2] INPUT/HID: add touch support for SiS touch driver

2015-01-09 Thread tammy_tseng
Hi, This package of patch is to add support for multitouch behavior for SiS touch products. The patch of SiS i2c multitouch driver is in input/touchscreen. Signed-off-by: Tammy Tseng tammy_ts...@sis.com -- diff --git a/linux-3.18.1/drivers/input/touchscreen/Kconfig