Re: [PATCH 1/2] Input: axp20x-pek: add support for AXP221 PEK

2017-07-18 Thread Quentin Schulz
Hi Maxime, On 18/07/2017 09:57, Maxime Ripard wrote: > On Tue, Jul 18, 2017 at 09:36:04AM +0200, Quentin Schulz wrote: + + error = sysfs_create_group(&pdev->dev.kobj, + axp20x_pek->attribute_group); >>> >>> Wouldn't it make more sense to just store the s

Re: [PATCH 1/2] Input: axp20x-pek: add support for AXP221 PEK

2017-07-18 Thread Maxime Ripard
On Tue, Jul 18, 2017 at 09:36:04AM +0200, Quentin Schulz wrote: > >> + > >> + error = sysfs_create_group(&pdev->dev.kobj, > >> + axp20x_pek->attribute_group); > > > > Wouldn't it make more sense to just store the startup_time structure > > in the axp20x_pek structure,

Re: [PATCH 1/2] Input: axp20x-pek: add support for AXP221 PEK

2017-07-18 Thread Quentin Schulz
Hi Maxime, On 17/07/2017 13:29, Maxime Ripard wrote: > Hi, > > On Mon, Jul 17, 2017 at 11:53:06AM +0200, Quentin Schulz wrote: >> The AXP221 has different values for startup time bits from the AXP20X. >> >> This patch introduces a different platform_device_id to the driver and >> adds the necessa

Re: [PATCH 1/2] Input: axp20x-pek: add support for AXP221 PEK

2017-07-17 Thread Maxime Ripard
Hi, On Mon, Jul 17, 2017 at 11:53:06AM +0200, Quentin Schulz wrote: > The AXP221 has different values for startup time bits from the AXP20X. > > This patch introduces a different platform_device_id to the driver and > adds the necessary code to handle the different platform_device_ids. > > Signe

[PATCH 1/2] Input: axp20x-pek: add support for AXP221 PEK

2017-07-17 Thread Quentin Schulz
The AXP221 has different values for startup time bits from the AXP20X. This patch introduces a different platform_device_id to the driver and adds the necessary code to handle the different platform_device_ids. Signed-off-by: Quentin Schulz --- drivers/input/misc/axp20x-pek.c | 62 +