Re: [PATCH 1/2] KVM: X86: remove read buffer for mmio read

2012-07-10 Thread Avi Kivity
On 07/10/2012 04:01 PM, Gleb Natapov wrote: > On Tue, Jul 10, 2012 at 03:50:39PM +0300, Avi Kivity wrote: > > On 07/10/2012 01:48 PM, Gleb Natapov wrote: > > > > > > > > > > > But the code is already here, why drop it? > > > > > > > > The read cache is not effective for multiple disjunct reads.

Re: [PATCH 1/2] KVM: X86: remove read buffer for mmio read

2012-07-10 Thread Gleb Natapov
On Tue, Jul 10, 2012 at 03:50:39PM +0300, Avi Kivity wrote: > On 07/10/2012 01:48 PM, Gleb Natapov wrote: > > > > > > > > > But the code is already here, why drop it? > > > > > > The read cache is not effective for multiple disjunct reads. > > What do you mean? > > If an instruction reads from

Re: [PATCH 1/2] KVM: X86: remove read buffer for mmio read

2012-07-10 Thread Avi Kivity
On 07/10/2012 01:48 PM, Gleb Natapov wrote: > > > > > > > But the code is already here, why drop it? > > > > The read cache is not effective for multiple disjunct reads. > What do you mean? If an instruction reads from several sources in mmio, then the first read will be flushed from the cache

Re: [PATCH 1/2] KVM: X86: remove read buffer for mmio read

2012-07-10 Thread Gleb Natapov
On Tue, Jul 10, 2012 at 01:45:15PM +0300, Avi Kivity wrote: > On 07/10/2012 01:36 PM, Gleb Natapov wrote: > > On Mon, Jul 09, 2012 at 04:34:50PM +0300, Avi Kivity wrote: > > > On 07/09/2012 04:23 PM, Xiao Guangrong wrote: > > > > On 07/09/2012 08:49 PM, Avi Kivity wrote: > > > >> On 07/09/2012

Re: [PATCH 1/2] KVM: X86: remove read buffer for mmio read

2012-07-10 Thread Avi Kivity
On 07/10/2012 01:36 PM, Gleb Natapov wrote: > On Mon, Jul 09, 2012 at 04:34:50PM +0300, Avi Kivity wrote: > > On 07/09/2012 04:23 PM, Xiao Guangrong wrote: > > > On 07/09/2012 08:49 PM, Avi Kivity wrote: > > >> On 07/09/2012 02:23 PM, Gleb Natapov wrote: > > >>> > > kvm-unit-tests.git has a

Re: [PATCH 1/2] KVM: X86: remove read buffer for mmio read

2012-07-10 Thread Gleb Natapov
On Mon, Jul 09, 2012 at 04:34:50PM +0300, Avi Kivity wrote: > On 07/09/2012 04:23 PM, Xiao Guangrong wrote: > > On 07/09/2012 08:49 PM, Avi Kivity wrote: > >> On 07/09/2012 02:23 PM, Gleb Natapov wrote: > >>> > kvm-unit-tests.git has a test for xchg to mmio. Does it still work? > >

Re: [PATCH 1/2] KVM: X86: remove read buffer for mmio read

2012-07-10 Thread Gleb Natapov
On Mon, Jul 09, 2012 at 04:34:50PM +0300, Avi Kivity wrote: On 07/09/2012 04:23 PM, Xiao Guangrong wrote: On 07/09/2012 08:49 PM, Avi Kivity wrote: On 07/09/2012 02:23 PM, Gleb Natapov wrote: kvm-unit-tests.git has a test for xchg to mmio. Does it still work? I agree this code has to

Re: [PATCH 1/2] KVM: X86: remove read buffer for mmio read

2012-07-10 Thread Avi Kivity
On 07/10/2012 01:36 PM, Gleb Natapov wrote: On Mon, Jul 09, 2012 at 04:34:50PM +0300, Avi Kivity wrote: On 07/09/2012 04:23 PM, Xiao Guangrong wrote: On 07/09/2012 08:49 PM, Avi Kivity wrote: On 07/09/2012 02:23 PM, Gleb Natapov wrote: kvm-unit-tests.git has a test for xchg to mmio.

Re: [PATCH 1/2] KVM: X86: remove read buffer for mmio read

2012-07-10 Thread Gleb Natapov
On Tue, Jul 10, 2012 at 01:45:15PM +0300, Avi Kivity wrote: On 07/10/2012 01:36 PM, Gleb Natapov wrote: On Mon, Jul 09, 2012 at 04:34:50PM +0300, Avi Kivity wrote: On 07/09/2012 04:23 PM, Xiao Guangrong wrote: On 07/09/2012 08:49 PM, Avi Kivity wrote: On 07/09/2012 02:23 PM, Gleb

Re: [PATCH 1/2] KVM: X86: remove read buffer for mmio read

2012-07-10 Thread Avi Kivity
On 07/10/2012 01:48 PM, Gleb Natapov wrote: But the code is already here, why drop it? The read cache is not effective for multiple disjunct reads. What do you mean? If an instruction reads from several sources in mmio, then the first read will be flushed from the cache by the

Re: [PATCH 1/2] KVM: X86: remove read buffer for mmio read

2012-07-10 Thread Gleb Natapov
On Tue, Jul 10, 2012 at 03:50:39PM +0300, Avi Kivity wrote: On 07/10/2012 01:48 PM, Gleb Natapov wrote: But the code is already here, why drop it? The read cache is not effective for multiple disjunct reads. What do you mean? If an instruction reads from several sources in

Re: [PATCH 1/2] KVM: X86: remove read buffer for mmio read

2012-07-10 Thread Avi Kivity
On 07/10/2012 04:01 PM, Gleb Natapov wrote: On Tue, Jul 10, 2012 at 03:50:39PM +0300, Avi Kivity wrote: On 07/10/2012 01:48 PM, Gleb Natapov wrote: But the code is already here, why drop it? The read cache is not effective for multiple disjunct reads. What do you mean?

Re: [PATCH 1/2] KVM: X86: remove read buffer for mmio read

2012-07-09 Thread Avi Kivity
On 07/09/2012 04:23 PM, Xiao Guangrong wrote: > On 07/09/2012 08:49 PM, Avi Kivity wrote: >> On 07/09/2012 02:23 PM, Gleb Natapov wrote: >>> kvm-unit-tests.git has a test for xchg to mmio. Does it still work? I agree this code has to go, but it needs to be replaced by something.

Re: [PATCH 1/2] KVM: X86: remove read buffer for mmio read

2012-07-09 Thread Gleb Natapov
On Mon, Jul 09, 2012 at 09:23:03PM +0800, Xiao Guangrong wrote: > On 07/09/2012 08:49 PM, Avi Kivity wrote: > > On 07/09/2012 02:23 PM, Gleb Natapov wrote: > >> > >>> kvm-unit-tests.git has a test for xchg to mmio. Does it still work? > >>> > >>> I agree this code has to go, but it needs to be

Re: [PATCH 1/2] KVM: X86: remove read buffer for mmio read

2012-07-09 Thread Gleb Natapov
On Mon, Jul 09, 2012 at 03:49:05PM +0300, Avi Kivity wrote: > On 07/09/2012 02:23 PM, Gleb Natapov wrote: > > > >> kvm-unit-tests.git has a test for xchg to mmio. Does it still work? > >> > >> I agree this code has to go, but it needs to be replaced by something. > >> Maybe a .valid flag in

Re: [PATCH 1/2] KVM: X86: remove read buffer for mmio read

2012-07-09 Thread Xiao Guangrong
On 07/09/2012 08:49 PM, Avi Kivity wrote: > On 07/09/2012 02:23 PM, Gleb Natapov wrote: >> >>> kvm-unit-tests.git has a test for xchg to mmio. Does it still work? >>> >>> I agree this code has to go, but it needs to be replaced by something. >>> Maybe a .valid flag in struct operand. >>> >> Valid

Re: [PATCH 1/2] KVM: X86: remove read buffer for mmio read

2012-07-09 Thread Avi Kivity
On 07/09/2012 02:23 PM, Gleb Natapov wrote: > >> kvm-unit-tests.git has a test for xchg to mmio. Does it still work? >> >> I agree this code has to go, but it needs to be replaced by something. >> Maybe a .valid flag in struct operand. >> > Valid will not enough for that. If we make

Re: [PATCH 1/2] KVM: X86: remove read buffer for mmio read

2012-07-09 Thread Avi Kivity
On 07/09/2012 02:23 PM, Gleb Natapov wrote: > >> kvm-unit-tests.git has a test for xchg to mmio. Does it still work? >> >> I agree this code has to go, but it needs to be replaced by something. >> Maybe a .valid flag in struct operand. >> > Valid will not enough for that. If me make

Re: [PATCH 1/2] KVM: X86: remove read buffer for mmio read

2012-07-09 Thread Gleb Natapov
On Mon, Jul 09, 2012 at 02:15:37PM +0300, Avi Kivity wrote: > On 07/09/2012 12:02 PM, Xiao Guangrong wrote: > > After commit f78146b0f9230765c6315b2e14f56112513389ad: > > > > KVM: Fix page-crossing MMIO > > > > MMIO that are split across a page boundary are currently broken - the > >

Re: [PATCH 1/2] KVM: X86: remove read buffer for mmio read

2012-07-09 Thread Avi Kivity
On 07/09/2012 12:02 PM, Xiao Guangrong wrote: > After commit f78146b0f9230765c6315b2e14f56112513389ad: > > KVM: Fix page-crossing MMIO > > MMIO that are split across a page boundary are currently broken - the > code does not expect to be aborted by the exit to userspace for the >

[PATCH 1/2] KVM: X86: remove read buffer for mmio read

2012-07-09 Thread Xiao Guangrong
After commit f78146b0f9230765c6315b2e14f56112513389ad: KVM: Fix page-crossing MMIO MMIO that are split across a page boundary are currently broken - the code does not expect to be aborted by the exit to userspace for the first MMIO fragment. This patch fixes the problem by

[PATCH 1/2] KVM: X86: remove read buffer for mmio read

2012-07-09 Thread Xiao Guangrong
After commit f78146b0f9230765c6315b2e14f56112513389ad: KVM: Fix page-crossing MMIO MMIO that are split across a page boundary are currently broken - the code does not expect to be aborted by the exit to userspace for the first MMIO fragment. This patch fixes the problem by

Re: [PATCH 1/2] KVM: X86: remove read buffer for mmio read

2012-07-09 Thread Avi Kivity
On 07/09/2012 12:02 PM, Xiao Guangrong wrote: After commit f78146b0f9230765c6315b2e14f56112513389ad: KVM: Fix page-crossing MMIO MMIO that are split across a page boundary are currently broken - the code does not expect to be aborted by the exit to userspace for the first

Re: [PATCH 1/2] KVM: X86: remove read buffer for mmio read

2012-07-09 Thread Gleb Natapov
On Mon, Jul 09, 2012 at 02:15:37PM +0300, Avi Kivity wrote: On 07/09/2012 12:02 PM, Xiao Guangrong wrote: After commit f78146b0f9230765c6315b2e14f56112513389ad: KVM: Fix page-crossing MMIO MMIO that are split across a page boundary are currently broken - the code does not

Re: [PATCH 1/2] KVM: X86: remove read buffer for mmio read

2012-07-09 Thread Avi Kivity
On 07/09/2012 02:23 PM, Gleb Natapov wrote: kvm-unit-tests.git has a test for xchg to mmio. Does it still work? I agree this code has to go, but it needs to be replaced by something. Maybe a .valid flag in struct operand. Valid will not enough for that. If me make everything go through

Re: [PATCH 1/2] KVM: X86: remove read buffer for mmio read

2012-07-09 Thread Avi Kivity
On 07/09/2012 02:23 PM, Gleb Natapov wrote: kvm-unit-tests.git has a test for xchg to mmio. Does it still work? I agree this code has to go, but it needs to be replaced by something. Maybe a .valid flag in struct operand. Valid will not enough for that. If we make everything go through

Re: [PATCH 1/2] KVM: X86: remove read buffer for mmio read

2012-07-09 Thread Xiao Guangrong
On 07/09/2012 08:49 PM, Avi Kivity wrote: On 07/09/2012 02:23 PM, Gleb Natapov wrote: kvm-unit-tests.git has a test for xchg to mmio. Does it still work? I agree this code has to go, but it needs to be replaced by something. Maybe a .valid flag in struct operand. Valid will not enough for

Re: [PATCH 1/2] KVM: X86: remove read buffer for mmio read

2012-07-09 Thread Gleb Natapov
On Mon, Jul 09, 2012 at 03:49:05PM +0300, Avi Kivity wrote: On 07/09/2012 02:23 PM, Gleb Natapov wrote: kvm-unit-tests.git has a test for xchg to mmio. Does it still work? I agree this code has to go, but it needs to be replaced by something. Maybe a .valid flag in struct operand.

Re: [PATCH 1/2] KVM: X86: remove read buffer for mmio read

2012-07-09 Thread Gleb Natapov
On Mon, Jul 09, 2012 at 09:23:03PM +0800, Xiao Guangrong wrote: On 07/09/2012 08:49 PM, Avi Kivity wrote: On 07/09/2012 02:23 PM, Gleb Natapov wrote: kvm-unit-tests.git has a test for xchg to mmio. Does it still work? I agree this code has to go, but it needs to be replaced by

Re: [PATCH 1/2] KVM: X86: remove read buffer for mmio read

2012-07-09 Thread Avi Kivity
On 07/09/2012 04:23 PM, Xiao Guangrong wrote: On 07/09/2012 08:49 PM, Avi Kivity wrote: On 07/09/2012 02:23 PM, Gleb Natapov wrote: kvm-unit-tests.git has a test for xchg to mmio. Does it still work? I agree this code has to go, but it needs to be replaced by something. Maybe a .valid flag