Re: [PATCH 1/2] KVM: x86: fix reporting of AMD speculation bug CPUID leaf

2019-08-19 Thread Paolo Bonzini
On 19/08/19 20:30, Jim Mattson wrote: >>> Perhaps there is another patch coming for reporting Intel bits on AMD? >> I wasn't going to work on it but yes, they should be. This patch just >> fixed what was half-implemented. > I'm not sure that the original intent was to enumerate the AMD > features

Re: [PATCH 1/2] KVM: x86: fix reporting of AMD speculation bug CPUID leaf

2019-08-19 Thread Jim Mattson
On Mon, Aug 19, 2019 at 8:18 AM Paolo Bonzini wrote: > > On 16/08/19 23:45, Jim Mattson wrote: > > On Thu, Aug 15, 2019 at 12:41 AM Paolo Bonzini wrote: > >> > >> The AMD_* bits have to be set from the vendor-independent > >> feature and bug flags, because KVM_GET_SUPPORTED_CPUID does not care >

Re: [PATCH 1/2] KVM: x86: fix reporting of AMD speculation bug CPUID leaf

2019-08-19 Thread Paolo Bonzini
On 16/08/19 23:45, Jim Mattson wrote: > On Thu, Aug 15, 2019 at 12:41 AM Paolo Bonzini wrote: >> >> The AMD_* bits have to be set from the vendor-independent >> feature and bug flags, because KVM_GET_SUPPORTED_CPUID does not care >> about the vendor and they should be set on Intel processors as

Re: [PATCH 1/2] KVM: x86: fix reporting of AMD speculation bug CPUID leaf

2019-08-16 Thread Jim Mattson
On Thu, Aug 15, 2019 at 12:41 AM Paolo Bonzini wrote: > > The AMD_* bits have to be set from the vendor-independent > feature and bug flags, because KVM_GET_SUPPORTED_CPUID does not care > about the vendor and they should be set on Intel processors as well. > On top of this, SSBD, STIBP and

[PATCH 1/2] KVM: x86: fix reporting of AMD speculation bug CPUID leaf

2019-08-15 Thread Paolo Bonzini
The AMD_* bits have to be set from the vendor-independent feature and bug flags, because KVM_GET_SUPPORTED_CPUID does not care about the vendor and they should be set on Intel processors as well. On top of this, SSBD, STIBP and AMD_SSB_NO bit were not set, and VIRT_SSBD does not have to be added