Re: [PATCH 1/2] MIPS: OCTEON: fix kernel crash when offlining a CPU

2015-01-15 Thread Aaro Koskinen
Hi, On Thu, Jan 15, 2015 at 12:10:08PM -0800, David Daney wrote: > On 01/15/2015 11:53 AM, Aaro Koskinen wrote: > >Hi, > > > >On Thu, Jan 15, 2015 at 11:36:12AM -0800, David Daney wrote: > >>On 01/15/2015 10:49 AM, Aaro Koskinen wrote: > >>>octeon_cpu_disable() will unconditionally enable

Re: [PATCH 1/2] MIPS: OCTEON: fix kernel crash when offlining a CPU

2015-01-15 Thread David Daney
On 01/15/2015 11:53 AM, Aaro Koskinen wrote: Hi, On Thu, Jan 15, 2015 at 11:36:12AM -0800, David Daney wrote: On 01/15/2015 10:49 AM, Aaro Koskinen wrote: octeon_cpu_disable() will unconditionally enable interrupts when called with interrupts disabled. Fix that. interrupts are always

Re: [PATCH 1/2] MIPS: OCTEON: fix kernel crash when offlining a CPU

2015-01-15 Thread Aaro Koskinen
Hi, On Thu, Jan 15, 2015 at 11:36:12AM -0800, David Daney wrote: > On 01/15/2015 10:49 AM, Aaro Koskinen wrote: > >octeon_cpu_disable() will unconditionally enable interrupts when called > >with interrupts disabled. Fix that. > > interrupts are always disabled here, so... Is that also true for

Re: [PATCH 1/2] MIPS: OCTEON: fix kernel crash when offlining a CPU

2015-01-15 Thread David Daney
On 01/15/2015 10:49 AM, Aaro Koskinen wrote: octeon_cpu_disable() will unconditionally enable interrupts when called with interrupts disabled. Fix that. interrupts are always disabled here, so... [...] Reported-by: Hemmo Nieminen Signed-off-by: Aaro Koskinen Cc: sta...@vger.kernel.org

[PATCH 1/2] MIPS: OCTEON: fix kernel crash when offlining a CPU

2015-01-15 Thread Aaro Koskinen
octeon_cpu_disable() will unconditionally enable interrupts when called with interrupts disabled. Fix that. The patch fixes the following crash when offlining a CPU: [ 93.818785] [ cut here ] [ 93.823421] WARNING: CPU: 1 PID: 10 at kernel/smp.c:231

[PATCH 1/2] MIPS: OCTEON: fix kernel crash when offlining a CPU

2015-01-15 Thread Aaro Koskinen
octeon_cpu_disable() will unconditionally enable interrupts when called with interrupts disabled. Fix that. The patch fixes the following crash when offlining a CPU: [ 93.818785] [ cut here ] [ 93.823421] WARNING: CPU: 1 PID: 10 at kernel/smp.c:231

Re: [PATCH 1/2] MIPS: OCTEON: fix kernel crash when offlining a CPU

2015-01-15 Thread Aaro Koskinen
Hi, On Thu, Jan 15, 2015 at 11:36:12AM -0800, David Daney wrote: On 01/15/2015 10:49 AM, Aaro Koskinen wrote: octeon_cpu_disable() will unconditionally enable interrupts when called with interrupts disabled. Fix that. interrupts are always disabled here, so... Is that also true for all the

Re: [PATCH 1/2] MIPS: OCTEON: fix kernel crash when offlining a CPU

2015-01-15 Thread Aaro Koskinen
Hi, On Thu, Jan 15, 2015 at 12:10:08PM -0800, David Daney wrote: On 01/15/2015 11:53 AM, Aaro Koskinen wrote: Hi, On Thu, Jan 15, 2015 at 11:36:12AM -0800, David Daney wrote: On 01/15/2015 10:49 AM, Aaro Koskinen wrote: octeon_cpu_disable() will unconditionally enable interrupts when

Re: [PATCH 1/2] MIPS: OCTEON: fix kernel crash when offlining a CPU

2015-01-15 Thread David Daney
On 01/15/2015 11:53 AM, Aaro Koskinen wrote: Hi, On Thu, Jan 15, 2015 at 11:36:12AM -0800, David Daney wrote: On 01/15/2015 10:49 AM, Aaro Koskinen wrote: octeon_cpu_disable() will unconditionally enable interrupts when called with interrupts disabled. Fix that. interrupts are always

Re: [PATCH 1/2] MIPS: OCTEON: fix kernel crash when offlining a CPU

2015-01-15 Thread David Daney
On 01/15/2015 10:49 AM, Aaro Koskinen wrote: octeon_cpu_disable() will unconditionally enable interrupts when called with interrupts disabled. Fix that. interrupts are always disabled here, so... [...] Reported-by: Hemmo Nieminen hemmo.niemi...@iki.fi Signed-off-by: Aaro Koskinen