On Fri, Oct 19, 2012 at 3:58 PM, Linus Torvalds
wrote:
>
> Also, I wonder how standard this /usr/bin/perl is:
>
>> +#!/usr/bin/perl -w
Well, we have other uses of that path in the kernel already, and your
v3 patch uses 'perl' in the Makefile to run it, so it will pick up the
path that way.
So I
This version still seems to have some debug turds in it:
On Fri, Oct 19, 2012 at 3:51 PM, David Howells wrote:
>
> + printk("Check for sig\n");
> +
...
> + printk("Found sig\n");
...
> +#define DEBUG
Also, I wonder how standard this /usr/bin/perl is:
>
Turn sign-file into perl and merge in x509keyid. The latter doesn't need to be
a separate script as it doesn't actually need to work out the SHA1 sum of the
X.509 certificate itself, since it can get that from the X.509 certificate.
Signed-off-by: David Howells
---
Makefile |2
David Howells wrote:
> + printk("Check for sig\n");
> +
> ...
> + printk("Found sig\n");
> ...
> +#define DEBUG
And I also forgot to remove the debugging. Sigh.
David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
Turn sign-file into perl and merge in x509keyid. The latter doesn't need to be
a separate script as it doesn't actually need to work out the SHA1 sum of the
X.509 certificate itself, since it can get that from the X.509 certificate.
Signed-off-by: David Howells
---
Makefile|
David Howells wrote:
> -mod_sign_cmd = sh $(srctree)/scripts/sign-file $(MODSECKEY) $(MODPUBKEY)
> $(srctree)/scripts/x509keyid
> +mod_sign_cmd = sh $(srctree)/scripts/sign-file $(MODSECKEY) $(MODPUBKEY)
Hmmm... That's not quite right. That needs to be 'perl' not 'sh'.
David
--
To
Turn sign-file into perl and merge in x509keyid. The latter doesn't need to be
a separate script as it doesn't actually need to work out the SHA1 sum of the
X.509 certificate itself, since it can get that from the X.509 certificate.
Signed-off-by: David Howells
---
Makefile|
Turn sign-file into perl and merge in x509keyid. The latter doesn't need to be
a separate script as it doesn't actually need to work out the SHA1 sum of the
X.509 certificate itself, since it can get that from the X.509 certificate.
Signed-off-by: David Howells dhowe...@redhat.com
---
Makefile
David Howells dhowe...@redhat.com wrote:
-mod_sign_cmd = sh $(srctree)/scripts/sign-file $(MODSECKEY) $(MODPUBKEY)
$(srctree)/scripts/x509keyid
+mod_sign_cmd = sh $(srctree)/scripts/sign-file $(MODSECKEY) $(MODPUBKEY)
Hmmm... That's not quite right. That needs to be 'perl' not 'sh'.
David
Turn sign-file into perl and merge in x509keyid. The latter doesn't need to be
a separate script as it doesn't actually need to work out the SHA1 sum of the
X.509 certificate itself, since it can get that from the X.509 certificate.
Signed-off-by: David Howells dhowe...@redhat.com
---
Makefile
David Howells dhowe...@redhat.com wrote:
+ printk(Check for sig\n);
+
...
+ printk(Found sig\n);
...
+#define DEBUG
And I also forgot to remove the debugging. Sigh.
David
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a
Turn sign-file into perl and merge in x509keyid. The latter doesn't need to be
a separate script as it doesn't actually need to work out the SHA1 sum of the
X.509 certificate itself, since it can get that from the X.509 certificate.
Signed-off-by: David Howells dhowe...@redhat.com
---
Makefile
This version still seems to have some debug turds in it:
On Fri, Oct 19, 2012 at 3:51 PM, David Howells dhowe...@redhat.com wrote:
+ printk(Check for sig\n);
+
...
+ printk(Found sig\n);
...
+#define DEBUG
Also, I wonder how standard this /usr/bin/perl is:
On Fri, Oct 19, 2012 at 3:58 PM, Linus Torvalds
torva...@linux-foundation.org wrote:
Also, I wonder how standard this /usr/bin/perl is:
+#!/usr/bin/perl -w
Well, we have other uses of that path in the kernel already, and your
v3 patch uses 'perl' in the Makefile to run it, so it will pick up
14 matches
Mail list logo
