Re: [PATCH 1/2] Move and rename HP watchdog timer driver

2013-09-03 Thread Guenter Roeck
On 09/03/2013 10:51 PM, Matthew Garrett wrote: On Tue, 2013-09-03 at 22:43 -0700, Guenter Roeck wrote: If that is the case, wouldn't it make more sense to have separate drivers, one per functionality, plus an mfd driver to bind them all together ? It'd be an option, but I don't think there's

Re: [PATCH 1/2] Move and rename HP watchdog timer driver

2013-09-03 Thread Matthew Garrett
On Tue, 2013-09-03 at 22:43 -0700, Guenter Roeck wrote: > If that is the case, wouldn't it make more sense to have separate drivers, > one per functionality, plus an mfd driver to bind them all together ? It'd be an option, but I don't think there's a huge benefit - the functionality's reasonably

Re: [PATCH 1/2] Move and rename HP watchdog timer driver

2013-09-03 Thread Guenter Roeck
On 09/03/2013 10:29 PM, Matthew Garrett wrote: The HP watchdog timer driver binds to the HP iLO system support controller PCI device. This PCI device actually supports a wider range of functionality, so give the driver a more generic name and move it to the x86 platform driver directory in prepar

[PATCH 1/2] Move and rename HP watchdog timer driver

2013-09-03 Thread Matthew Garrett
The HP watchdog timer driver binds to the HP iLO system support controller PCI device. This PCI device actually supports a wider range of functionality, so give the driver a more generic name and move it to the x86 platform driver directory in preparation for the following changes. Signed-off-by: