Re: [PATCH 1/2] PCI: rockchip: Work around missing device_type property in DT

2020-08-18 Thread Rob Herring
On Tue, Aug 18, 2020 at 1:03 PM Marc Zyngier wrote: > > On 2020-08-18 18:48, Saravana Kannan wrote: > > On Tue, Aug 18, 2020 at 10:34 AM Marc Zyngier wrote: > > [...] > > >> OK. So how about something like this? > >> > >> diff --git a/drivers/of/address.c b/drivers/of/address.c > >> index

Re: [PATCH 1/2] PCI: rockchip: Work around missing device_type property in DT

2020-08-18 Thread Marc Zyngier
On 2020-08-18 18:48, Saravana Kannan wrote: On Tue, Aug 18, 2020 at 10:34 AM Marc Zyngier wrote: [...] OK. So how about something like this? diff --git a/drivers/of/address.c b/drivers/of/address.c index 590493e04b01..a7a6ee599b14 100644 --- a/drivers/of/address.c +++

Re: [PATCH 1/2] PCI: rockchip: Work around missing device_type property in DT

2020-08-18 Thread Saravana Kannan
On Tue, Aug 18, 2020 at 10:34 AM Marc Zyngier wrote: > > On 2020-08-18 15:23, Rob Herring wrote: > > On Tue, Aug 18, 2020 at 1:35 AM Marc Zyngier wrote: > >> > >> On 2020-08-17 17:12, Rob Herring wrote: > >> > On Sun, Aug 16, 2020 at 4:40 AM Marc Zyngier wrote: > >> >> > >> >> On Sun, 16 Aug

Re: [PATCH 1/2] PCI: rockchip: Work around missing device_type property in DT

2020-08-18 Thread Marc Zyngier
On 2020-08-18 15:23, Rob Herring wrote: On Tue, Aug 18, 2020 at 1:35 AM Marc Zyngier wrote: On 2020-08-17 17:12, Rob Herring wrote: > On Sun, Aug 16, 2020 at 4:40 AM Marc Zyngier wrote: >> >> On Sun, 16 Aug 2020 00:22:28 +0100, >> Bjorn Helgaas wrote: >> > >> > On Sat, Aug 15, 2020 at

Re: [PATCH 1/2] PCI: rockchip: Work around missing device_type property in DT

2020-08-18 Thread Rob Herring
On Tue, Aug 18, 2020 at 1:35 AM Marc Zyngier wrote: > > On 2020-08-17 17:12, Rob Herring wrote: > > On Sun, Aug 16, 2020 at 4:40 AM Marc Zyngier wrote: > >> > >> On Sun, 16 Aug 2020 00:22:28 +0100, > >> Bjorn Helgaas wrote: > >> > > >> > On Sat, Aug 15, 2020 at 01:51:11PM +0100, Marc Zyngier

Re: [PATCH 1/2] PCI: rockchip: Work around missing device_type property in DT

2020-08-18 Thread Marc Zyngier
On 2020-08-17 17:12, Rob Herring wrote: On Sun, Aug 16, 2020 at 4:40 AM Marc Zyngier wrote: On Sun, 16 Aug 2020 00:22:28 +0100, Bjorn Helgaas wrote: > > On Sat, Aug 15, 2020 at 01:51:11PM +0100, Marc Zyngier wrote: > > Recent changes to the DT PCI bus parsing made it mandatory for > > device

Re: [PATCH 1/2] PCI: rockchip: Work around missing device_type property in DT

2020-08-17 Thread Rob Herring
On Sun, Aug 16, 2020 at 4:40 AM Marc Zyngier wrote: > > On Sun, 16 Aug 2020 00:22:28 +0100, > Bjorn Helgaas wrote: > > > > On Sat, Aug 15, 2020 at 01:51:11PM +0100, Marc Zyngier wrote: > > > Recent changes to the DT PCI bus parsing made it mandatory for > > > device tree nodes describing a PCI

Re: [PATCH 1/2] PCI: rockchip: Work around missing device_type property in DT

2020-08-16 Thread Marc Zyngier
On Sun, 16 Aug 2020 00:22:28 +0100, Bjorn Helgaas wrote: > > On Sat, Aug 15, 2020 at 01:51:11PM +0100, Marc Zyngier wrote: > > Recent changes to the DT PCI bus parsing made it mandatory for > > device tree nodes describing a PCI controller to have the > > 'device_type = "pci"' property for the

Re: [PATCH 1/2] PCI: rockchip: Work around missing device_type property in DT

2020-08-15 Thread Bjorn Helgaas
On Sat, Aug 15, 2020 at 01:51:11PM +0100, Marc Zyngier wrote: > Recent changes to the DT PCI bus parsing made it mandatory for > device tree nodes describing a PCI controller to have the > 'device_type = "pci"' property for the node to be matched. > > Although this follows the letter of the

[PATCH 1/2] PCI: rockchip: Work around missing device_type property in DT

2020-08-15 Thread Marc Zyngier
Recent changes to the DT PCI bus parsing made it mandatory for device tree nodes describing a PCI controller to have the 'device_type = "pci"' property for the node to be matched. Although this follows the letter of the specification, it breaks existing device-trees that have been working fine