Re: [PATCH 1/2] PM / wakeup: Remove timer from wakeup_source_remove()

2019-03-12 Thread Viresh Kumar
On 12-03-19, 10:04, Pavel Machek wrote: > On Tue 2019-03-12 08:58:02, Viresh Kumar wrote: > > On 11-03-19, 13:05, Rafael J. Wysocki wrote: > > > On Friday, March 8, 2019 10:53:11 AM CET Viresh Kumar wrote: > > > > wakeup_source_remove() is the counterpart of wakeup_source_add() helper > > > > and m

Re: [PATCH 1/2] PM / wakeup: Remove timer from wakeup_source_remove()

2019-03-12 Thread Pavel Machek
On Tue 2019-03-12 08:58:02, Viresh Kumar wrote: > On 11-03-19, 13:05, Rafael J. Wysocki wrote: > > On Friday, March 8, 2019 10:53:11 AM CET Viresh Kumar wrote: > > > wakeup_source_remove() is the counterpart of wakeup_source_add() helper > > > and must undo the initializations done by wakeup_source

Re: [PATCH 1/2] PM / wakeup: Remove timer from wakeup_source_remove()

2019-03-12 Thread Rafael J. Wysocki
On Tue, Mar 12, 2019 at 4:28 AM Viresh Kumar wrote: > > On 11-03-19, 13:05, Rafael J. Wysocki wrote: > > On Friday, March 8, 2019 10:53:11 AM CET Viresh Kumar wrote: > > > wakeup_source_remove() is the counterpart of wakeup_source_add() helper > > > and must undo the initializations done by wakeup

Re: [PATCH 1/2] PM / wakeup: Remove timer from wakeup_source_remove()

2019-03-11 Thread Viresh Kumar
On 11-03-19, 13:05, Rafael J. Wysocki wrote: > On Friday, March 8, 2019 10:53:11 AM CET Viresh Kumar wrote: > > wakeup_source_remove() is the counterpart of wakeup_source_add() helper > > and must undo the initializations done by wakeup_source_add(). Currently > > the timer is initialized by wakeup

Re: [PATCH 1/2] PM / wakeup: Remove timer from wakeup_source_remove()

2019-03-11 Thread Rafael J. Wysocki
On Friday, March 8, 2019 10:53:11 AM CET Viresh Kumar wrote: > wakeup_source_remove() is the counterpart of wakeup_source_add() helper > and must undo the initializations done by wakeup_source_add(). Currently > the timer is initialized by wakeup_source_add() but removed from > wakeup_source_drop()

[PATCH 1/2] PM / wakeup: Remove timer from wakeup_source_remove()

2019-03-08 Thread Viresh Kumar
wakeup_source_remove() is the counterpart of wakeup_source_add() helper and must undo the initializations done by wakeup_source_add(). Currently the timer is initialized by wakeup_source_add() but removed from wakeup_source_drop(), which doesn't look logically correct. Also it should be okay to cal