Re: [PATCH 1/2] Regulator: mc34708: Add DT binding documentation

2015-05-11 Thread Javier Martinez Canillas
Hello Martin, I haven't looked at your regulator driver in detail so this is not a full review but I just noticed something so I wanted mention. > + > + > +Example: > +&i2c3 { > + pmic: mc34708@08 { > + compatible = "fsl,mc34708"; > + reg = <0x08>; > +

Re: [PATCH 1/2] Regulator: mc34708: Add DT binding documentation

2015-05-01 Thread Mark Brown
On Fri, May 01, 2015 at 02:33:44PM +0200, Stefan Wahren wrote: > > Mark Brown hat am 1. Mai 2015 um 13:01 geschrieben: > > On Fri, May 01, 2015 at 12:34:21PM +0200, Stefan Wahren wrote: > > > a commit message would be nice and the subject should specify dt-bindings > > > instead of regulator sub

Re: [PATCH 1/2] Regulator: mc34708: Add DT binding documentation

2015-05-01 Thread Stefan Wahren
Hi Mark, > Mark Brown hat am 1. Mai 2015 um 13:01 geschrieben: > > > On Fri, May 01, 2015 at 12:34:21PM +0200, Stefan Wahren wrote: > > > a commit message would be nice and the subject should specify dt-bindings > > instead of regulator subsystem. > > No, it shouldn't. DT bindings for a subsystem

Re: [PATCH 1/2] Regulator: mc34708: Add DT binding documentation

2015-05-01 Thread Mark Brown
On Fri, May 01, 2015 at 12:34:21PM +0200, Stefan Wahren wrote: > a commit message would be nice and the subject should specify dt-bindings > instead of regulator subsystem. No, it shouldn't. DT bindings for a subsystem go through the subsystem and the subsystem maintainer needs to see them to re

Re: [PATCH 1/2] Regulator: mc34708: Add DT binding documentation

2015-05-01 Thread Stefan Wahren
Hi Martin, > Martin Fuzzey hat am 28. April 2015 um 16:17 > geschrieben: > > > Signed-off-by: Martin Fuzzey a commit message would be nice and the subject should specify dt-bindings instead of regulator subsystem. Stefan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel

Re: [PATCH 1/2] Regulator: mc34708: Add DT binding documentation

2015-04-30 Thread Mark Brown
On Tue, Apr 28, 2015 at 04:17:38PM +0200, Martin Fuzzey wrote: > + pmic_sw3_reg: sw3 { > + regulator-name = "SW3"; > + regulator-min-microvolt = <65>; > + regulator-max-microvolt = <1425000>

[PATCH 1/2] Regulator: mc34708: Add DT binding documentation

2015-04-28 Thread Martin Fuzzey
Signed-off-by: Martin Fuzzey --- .../bindings/regulator/mc34708-regulator.txt | 198 1 file changed, 198 insertions(+) create mode 100644 Documentation/devicetree/bindings/regulator/mc34708-regulator.txt diff --git a/Documentation/devicetree/bindings/regulator/mc347