Re: [PATCH 1/2] UBI: replace MTD_UBI_BEB_LIMIT with module parameter

2012-08-17 Thread Richard Genoud
2012/8/17 Artem Bityutskiy : > Richard, would you please split this series differently: > > 1. Separate out the calculations to the get_bad_peb_limit() func. > 2. Invent > 2. Add the module parameter > 3. Extends the ioctl > 4. Removes the Kconfig option > > This will be much easier to review. ok,

Re: [PATCH 1/2] UBI: replace MTD_UBI_BEB_LIMIT with module parameter

2012-08-17 Thread Artem Bityutskiy
Richard, would you please split this series differently: 1. Separate out the calculations to the get_bad_peb_limit() func. 2. Invent 2. Add the module parameter 3. Extends the ioctl 4. Removes the Kconfig option This will be much easier to review. See also some comments below. > ---

Re: [PATCH 1/2] UBI: replace MTD_UBI_BEB_LIMIT with module parameter

2012-08-17 Thread Artem Bityutskiy
Richard, would you please split this series differently: 1. Separate out the calculations to the get_bad_peb_limit() func. 2. Invent 2. Add the module parameter 3. Extends the ioctl 4. Removes the Kconfig option This will be much easier to review. See also some comments below. ---

Re: [PATCH 1/2] UBI: replace MTD_UBI_BEB_LIMIT with module parameter

2012-08-17 Thread Richard Genoud
2012/8/17 Artem Bityutskiy dedeki...@gmail.com: Richard, would you please split this series differently: 1. Separate out the calculations to the get_bad_peb_limit() func. 2. Invent 2. Add the module parameter 3. Extends the ioctl 4. Removes the Kconfig option This will be much easier to

[PATCH 1/2] UBI: replace MTD_UBI_BEB_LIMIT with module parameter

2012-08-16 Thread Richard Genoud
This patch provides the possibility to adjust the "maximum expected number of bad blocks per 1024 blocks" (max_beb_per1024) for each mtd device. The majority of NAND devices have their max_beb_per1024 equal to 20, but sometimes it's more. Now, we can adjust that via a kernel parameter:

[PATCH 1/2] UBI: replace MTD_UBI_BEB_LIMIT with module parameter

2012-08-16 Thread Richard Genoud
This patch provides the possibility to adjust the maximum expected number of bad blocks per 1024 blocks (max_beb_per1024) for each mtd device. The majority of NAND devices have their max_beb_per1024 equal to 20, but sometimes it's more. Now, we can adjust that via a kernel parameter: