Re: [PATCH 1/2] acpi: arm64: add iort support for PMCG

2018-01-31 Thread Lorenzo Pieralisi
On Wed, Jan 31, 2018 at 12:10:47PM +, Shameerali Kolothum Thodi wrote: [...] > > I went back and re-read the patches, I think the point here is that the > > perf driver (ie PATCH 2 that, by the way, is not maiinline) uses > > devm_ioremap_resource() to map the counters and that's what is caus

RE: [PATCH 1/2] acpi: arm64: add iort support for PMCG

2018-01-31 Thread Shameerali Kolothum Thodi
; Mark Brown > ; Mark Salter ; linux-arm- > ker...@lists.infradead.org; Will Deacon ; Mark > Rutland ; Linuxarm > Subject: Re: [PATCH 1/2] acpi: arm64: add iort support for PMCG > > On Tue, Jan 30, 2018 at 10:39:20AM +, Shameerali Kolothum Thodi wrote: > > Hi

Re: [PATCH 1/2] acpi: arm64: add iort support for PMCG

2018-01-30 Thread Lorenzo Pieralisi
04, 2017 8:59 PM > > To: Will Deacon ; Mark Rutland > > > > Cc: Mark Langsdorf ; Jon Masters > > ; Timur Tabi ; linux- > > ker...@vger.kernel.org; Mark Brown ; Mark Salter > > ; nlee...@codeaurora.org; linux-arm- > > ker...@lists.infradead.org > > Subjec

RE: [PATCH 1/2] acpi: arm64: add iort support for PMCG

2018-01-30 Thread Shameerali Kolothum Thodi
imur Tabi ; linux- > ker...@vger.kernel.org; Mark Brown ; Mark Salter > ; nlee...@codeaurora.org; linux-arm- > ker...@lists.infradead.org > Subject: [PATCH 1/2] acpi: arm64: add iort support for PMCG > > Add support for the SMMU Performance Monitor Counter Group > information from

Re: [PATCH 1/2] acpi: arm64: add iort support for PMCG

2017-08-07 Thread Leeder, Neil
Hi Lorenzo, On 8/7/2017 12:44 PM, Lorenzo Pieralisi wrote: > On Fri, Aug 04, 2017 at 03:59:13PM -0400, Neil Leeder wrote: [...] >> +} else if (iort_node->type == ACPI_IORT_NODE_PMCG) { >> +if (iort_add_smmu_platform_device(iort_node)) >> +

Re: [PATCH 1/2] acpi: arm64: add iort support for PMCG

2017-08-07 Thread Leeder, Neil
Hi Robin, Thank you for the review. On 8/7/2017 7:17 AM, Robin Murphy wrote: > Hi Neil, > > On 04/08/17 20:59, Neil Leeder wrote: [...] >> +res[1].start = pmcg->base_address + SZ_64K; > > Ugh, I see there's a nasty spec hole here - IORT only defines one base > address, but SMMUv3 says *both*

Re: [PATCH 1/2] acpi: arm64: add iort support for PMCG

2017-08-07 Thread Lorenzo Pieralisi
On Fri, Aug 04, 2017 at 03:59:13PM -0400, Neil Leeder wrote: > Add support for the SMMU Performance Monitor Counter Group > information from ACPI. This is in preparation for its use > in the SMMU v3 PMU driver. > > Signed-off-by: Neil Leeder > --- > drivers/acpi/arm64/iort.c | 54 >

Re: [PATCH 1/2] acpi: arm64: add iort support for PMCG

2017-08-07 Thread Robin Murphy
Hi Neil, On 04/08/17 20:59, Neil Leeder wrote: > Add support for the SMMU Performance Monitor Counter Group > information from ACPI. This is in preparation for its use > in the SMMU v3 PMU driver. > > Signed-off-by: Neil Leeder > --- > drivers/acpi/arm64/iort.c | 54 > +

[PATCH 1/2] acpi: arm64: add iort support for PMCG

2017-08-04 Thread Neil Leeder
Add support for the SMMU Performance Monitor Counter Group information from ACPI. This is in preparation for its use in the SMMU v3 PMU driver. Signed-off-by: Neil Leeder --- drivers/acpi/arm64/iort.c | 54 +++ include/acpi/actbl2.h | 9 +++-