Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-26 Thread Punit Agrawal
Jonathan Cameron writes: [...] > > I'll test it when back in the office, but I had a similar issue with > memory only nodes when I moved the SRAT listing for cpus from the 4 > 4th mode to the 3rd node to fake some memory I could hot unplug. > This gave a memory only node for the last node on

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-26 Thread Punit Agrawal
Jonathan Cameron writes: [...] > > I'll test it when back in the office, but I had a similar issue with > memory only nodes when I moved the SRAT listing for cpus from the 4 > 4th mode to the 3rd node to fake some memory I could hot unplug. > This gave a memory only node for the last node on

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-26 Thread Punit Agrawal
Jonathan Cameron writes: [...] > > I'll test it when back in the office, but I had a similar issue with > memory only nodes when I moved the SRAT listing for cpus from the 4 > 4th mode to the 3rd node to fake some memory I could hot unplug. > This gave a memory only node for the last node on

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-26 Thread Punit Agrawal
Jonathan Cameron writes: [...] > > I'll test it when back in the office, but I had a similar issue with > memory only nodes when I moved the SRAT listing for cpus from the 4 > 4th mode to the 3rd node to fake some memory I could hot unplug. > This gave a memory only node for the last node on

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-22 Thread Jonathan Cameron
On Fri, 22 Jun 2018 11:24:38 +0100 Punit Agrawal wrote: > Michal Hocko writes: > > > On Fri 22-06-18 16:58:05, Hanjun Guo wrote: > >> On 2018/6/20 19:51, Punit Agrawal wrote: > >> > Xie XiuQi writes: > >> > > >> >> Hi Lorenzo, Punit, > >> >> > >> >> > >> >> On 2018/6/20 0:32, Lorenzo

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-22 Thread Jonathan Cameron
On Fri, 22 Jun 2018 11:24:38 +0100 Punit Agrawal wrote: > Michal Hocko writes: > > > On Fri 22-06-18 16:58:05, Hanjun Guo wrote: > >> On 2018/6/20 19:51, Punit Agrawal wrote: > >> > Xie XiuQi writes: > >> > > >> >> Hi Lorenzo, Punit, > >> >> > >> >> > >> >> On 2018/6/20 0:32, Lorenzo

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-22 Thread Punit Agrawal
Michal Hocko writes: > On Fri 22-06-18 16:58:05, Hanjun Guo wrote: >> On 2018/6/20 19:51, Punit Agrawal wrote: >> > Xie XiuQi writes: >> > >> >> Hi Lorenzo, Punit, >> >> >> >> >> >> On 2018/6/20 0:32, Lorenzo Pieralisi wrote: >> >>> On Tue, Jun 19, 2018 at 04:35:40PM +0100, Punit Agrawal

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-22 Thread Punit Agrawal
Michal Hocko writes: > On Fri 22-06-18 16:58:05, Hanjun Guo wrote: >> On 2018/6/20 19:51, Punit Agrawal wrote: >> > Xie XiuQi writes: >> > >> >> Hi Lorenzo, Punit, >> >> >> >> >> >> On 2018/6/20 0:32, Lorenzo Pieralisi wrote: >> >>> On Tue, Jun 19, 2018 at 04:35:40PM +0100, Punit Agrawal

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-22 Thread Michal Hocko
On Fri 22-06-18 16:58:05, Hanjun Guo wrote: > On 2018/6/20 19:51, Punit Agrawal wrote: > > Xie XiuQi writes: > > > >> Hi Lorenzo, Punit, > >> > >> > >> On 2018/6/20 0:32, Lorenzo Pieralisi wrote: > >>> On Tue, Jun 19, 2018 at 04:35:40PM +0100, Punit Agrawal wrote: > Michal Hocko writes: >

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-22 Thread Michal Hocko
On Fri 22-06-18 16:58:05, Hanjun Guo wrote: > On 2018/6/20 19:51, Punit Agrawal wrote: > > Xie XiuQi writes: > > > >> Hi Lorenzo, Punit, > >> > >> > >> On 2018/6/20 0:32, Lorenzo Pieralisi wrote: > >>> On Tue, Jun 19, 2018 at 04:35:40PM +0100, Punit Agrawal wrote: > Michal Hocko writes: >

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-22 Thread Hanjun Guo
On 2018/6/20 19:51, Punit Agrawal wrote: > Xie XiuQi writes: > >> Hi Lorenzo, Punit, >> >> >> On 2018/6/20 0:32, Lorenzo Pieralisi wrote: >>> On Tue, Jun 19, 2018 at 04:35:40PM +0100, Punit Agrawal wrote: Michal Hocko writes: > On Tue 19-06-18 15:54:26, Punit Agrawal wrote: >

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-22 Thread Hanjun Guo
On 2018/6/20 19:51, Punit Agrawal wrote: > Xie XiuQi writes: > >> Hi Lorenzo, Punit, >> >> >> On 2018/6/20 0:32, Lorenzo Pieralisi wrote: >>> On Tue, Jun 19, 2018 at 04:35:40PM +0100, Punit Agrawal wrote: Michal Hocko writes: > On Tue 19-06-18 15:54:26, Punit Agrawal wrote: >

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-20 Thread Punit Agrawal
Xie XiuQi writes: > Hi Lorenzo, Punit, > > > On 2018/6/20 0:32, Lorenzo Pieralisi wrote: >> On Tue, Jun 19, 2018 at 04:35:40PM +0100, Punit Agrawal wrote: >>> Michal Hocko writes: >>> On Tue 19-06-18 15:54:26, Punit Agrawal wrote: [...] > In terms of $SUBJECT, I wonder if it's

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-20 Thread Punit Agrawal
Xie XiuQi writes: > Hi Lorenzo, Punit, > > > On 2018/6/20 0:32, Lorenzo Pieralisi wrote: >> On Tue, Jun 19, 2018 at 04:35:40PM +0100, Punit Agrawal wrote: >>> Michal Hocko writes: >>> On Tue 19-06-18 15:54:26, Punit Agrawal wrote: [...] > In terms of $SUBJECT, I wonder if it's

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-19 Thread Xie XiuQi
Hi Lorenzo, Punit, On 2018/6/20 0:32, Lorenzo Pieralisi wrote: > On Tue, Jun 19, 2018 at 04:35:40PM +0100, Punit Agrawal wrote: >> Michal Hocko writes: >> >>> On Tue 19-06-18 15:54:26, Punit Agrawal wrote: >>> [...] In terms of $SUBJECT, I wonder if it's worth taking the original patch

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-19 Thread Xie XiuQi
Hi Lorenzo, Punit, On 2018/6/20 0:32, Lorenzo Pieralisi wrote: > On Tue, Jun 19, 2018 at 04:35:40PM +0100, Punit Agrawal wrote: >> Michal Hocko writes: >> >>> On Tue 19-06-18 15:54:26, Punit Agrawal wrote: >>> [...] In terms of $SUBJECT, I wonder if it's worth taking the original patch

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-19 Thread Lorenzo Pieralisi
On Tue, Jun 19, 2018 at 04:35:40PM +0100, Punit Agrawal wrote: > Michal Hocko writes: > > > On Tue 19-06-18 15:54:26, Punit Agrawal wrote: > > [...] > >> In terms of $SUBJECT, I wonder if it's worth taking the original patch > >> as a temporary fix (it'll also be easier to backport) while we

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-19 Thread Lorenzo Pieralisi
On Tue, Jun 19, 2018 at 04:35:40PM +0100, Punit Agrawal wrote: > Michal Hocko writes: > > > On Tue 19-06-18 15:54:26, Punit Agrawal wrote: > > [...] > >> In terms of $SUBJECT, I wonder if it's worth taking the original patch > >> as a temporary fix (it'll also be easier to backport) while we

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-19 Thread Punit Agrawal
Michal Hocko writes: > On Tue 19-06-18 15:54:26, Punit Agrawal wrote: > [...] >> In terms of $SUBJECT, I wonder if it's worth taking the original patch >> as a temporary fix (it'll also be easier to backport) while we work on >> fixing these other issues and enabling memoryless nodes. > > Well,

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-19 Thread Punit Agrawal
Michal Hocko writes: > On Tue 19-06-18 15:54:26, Punit Agrawal wrote: > [...] >> In terms of $SUBJECT, I wonder if it's worth taking the original patch >> as a temporary fix (it'll also be easier to backport) while we work on >> fixing these other issues and enabling memoryless nodes. > > Well,

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-19 Thread Michal Hocko
On Tue 19-06-18 15:54:26, Punit Agrawal wrote: [...] > In terms of $SUBJECT, I wonder if it's worth taking the original patch > as a temporary fix (it'll also be easier to backport) while we work on > fixing these other issues and enabling memoryless nodes. Well, x86 already does that but copying

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-19 Thread Michal Hocko
On Tue 19-06-18 15:54:26, Punit Agrawal wrote: [...] > In terms of $SUBJECT, I wonder if it's worth taking the original patch > as a temporary fix (it'll also be easier to backport) while we work on > fixing these other issues and enabling memoryless nodes. Well, x86 already does that but copying

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-19 Thread Punit Agrawal
Lorenzo Pieralisi writes: > On Tue, Jun 19, 2018 at 01:52:16PM +0100, Punit Agrawal wrote: >> Michal Hocko writes: >> >> > On Tue 19-06-18 20:03:07, Xie XiuQi wrote: >> > [...] >> >> I tested on a arm board with 128 cores 4 numa nodes, but I set >> >> CONFIG_NR_CPUS=72. >> >> Then node 3 is

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-19 Thread Punit Agrawal
Lorenzo Pieralisi writes: > On Tue, Jun 19, 2018 at 01:52:16PM +0100, Punit Agrawal wrote: >> Michal Hocko writes: >> >> > On Tue 19-06-18 20:03:07, Xie XiuQi wrote: >> > [...] >> >> I tested on a arm board with 128 cores 4 numa nodes, but I set >> >> CONFIG_NR_CPUS=72. >> >> Then node 3 is

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-19 Thread Lorenzo Pieralisi
On Tue, Jun 19, 2018 at 01:52:16PM +0100, Punit Agrawal wrote: > Michal Hocko writes: > > > On Tue 19-06-18 20:03:07, Xie XiuQi wrote: > > [...] > >> I tested on a arm board with 128 cores 4 numa nodes, but I set > >> CONFIG_NR_CPUS=72. > >> Then node 3 is not be created, because node 3 has no

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-19 Thread Lorenzo Pieralisi
On Tue, Jun 19, 2018 at 01:52:16PM +0100, Punit Agrawal wrote: > Michal Hocko writes: > > > On Tue 19-06-18 20:03:07, Xie XiuQi wrote: > > [...] > >> I tested on a arm board with 128 cores 4 numa nodes, but I set > >> CONFIG_NR_CPUS=72. > >> Then node 3 is not be created, because node 3 has no

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-19 Thread Punit Agrawal
Michal Hocko writes: > On Tue 19-06-18 20:03:07, Xie XiuQi wrote: > [...] >> I tested on a arm board with 128 cores 4 numa nodes, but I set >> CONFIG_NR_CPUS=72. >> Then node 3 is not be created, because node 3 has no memory, and no cpu. >> But some pci device may related to node 3, which be

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-19 Thread Punit Agrawal
Michal Hocko writes: > On Tue 19-06-18 20:03:07, Xie XiuQi wrote: > [...] >> I tested on a arm board with 128 cores 4 numa nodes, but I set >> CONFIG_NR_CPUS=72. >> Then node 3 is not be created, because node 3 has no memory, and no cpu. >> But some pci device may related to node 3, which be

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-19 Thread Xie XiuQi
Hi Michal, On 2018/6/19 20:07, Michal Hocko wrote: > On Tue 19-06-18 20:03:07, Xie XiuQi wrote: > [...] >> I tested on a arm board with 128 cores 4 numa nodes, but I set >> CONFIG_NR_CPUS=72. >> Then node 3 is not be created, because node 3 has no memory, and no cpu. >> But some pci device may

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-19 Thread Xie XiuQi
Hi Michal, On 2018/6/19 20:07, Michal Hocko wrote: > On Tue 19-06-18 20:03:07, Xie XiuQi wrote: > [...] >> I tested on a arm board with 128 cores 4 numa nodes, but I set >> CONFIG_NR_CPUS=72. >> Then node 3 is not be created, because node 3 has no memory, and no cpu. >> But some pci device may

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-19 Thread Michal Hocko
On Tue 19-06-18 20:03:07, Xie XiuQi wrote: [...] > I tested on a arm board with 128 cores 4 numa nodes, but I set > CONFIG_NR_CPUS=72. > Then node 3 is not be created, because node 3 has no memory, and no cpu. > But some pci device may related to node 3, which be set in ACPI table. Could you

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-19 Thread Michal Hocko
On Tue 19-06-18 20:03:07, Xie XiuQi wrote: [...] > I tested on a arm board with 128 cores 4 numa nodes, but I set > CONFIG_NR_CPUS=72. > Then node 3 is not be created, because node 3 has no memory, and no cpu. > But some pci device may related to node 3, which be set in ACPI table. Could you

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-19 Thread Xie XiuQi
Hi Punit, On 2018/6/14 1:39, Punit Agrawal wrote: > Punit Agrawal writes: > > > [...] > >> >> CONFIG_HAVE_MEMORYLESS node is not enabled on arm64 which means we end >> up returning the original node in the fallback path. >> >> Xie, does the below patch help? I can submit a proper patch if

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-19 Thread Xie XiuQi
Hi Punit, On 2018/6/14 1:39, Punit Agrawal wrote: > Punit Agrawal writes: > > > [...] > >> >> CONFIG_HAVE_MEMORYLESS node is not enabled on arm64 which means we end >> up returning the original node in the fallback path. >> >> Xie, does the below patch help? I can submit a proper patch if

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-14 Thread Hanjun Guo
Hi Punit, On 2018/6/14 1:39, Punit Agrawal wrote: > Punit Agrawal writes: > > > [...] > >> >> CONFIG_HAVE_MEMORYLESS node is not enabled on arm64 which means we end >> up returning the original node in the fallback path. >> >> Xie, does the below patch help? I can submit a proper patch if

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-14 Thread Hanjun Guo
Hi Punit, On 2018/6/14 1:39, Punit Agrawal wrote: > Punit Agrawal writes: > > > [...] > >> >> CONFIG_HAVE_MEMORYLESS node is not enabled on arm64 which means we end >> up returning the original node in the fallback path. >> >> Xie, does the below patch help? I can submit a proper patch if

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-13 Thread Punit Agrawal
Punit Agrawal writes: [...] > > CONFIG_HAVE_MEMORYLESS node is not enabled on arm64 which means we end > up returning the original node in the fallback path. > > Xie, does the below patch help? I can submit a proper patch if this > fixes the issue for you. > > -- >8 -- > Subject: [PATCH]

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-13 Thread Punit Agrawal
Punit Agrawal writes: [...] > > CONFIG_HAVE_MEMORYLESS node is not enabled on arm64 which means we end > up returning the original node in the fallback path. > > Xie, does the below patch help? I can submit a proper patch if this > fixes the issue for you. > > -- >8 -- > Subject: [PATCH]

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-12 Thread Michal Hocko
On Tue 12-06-18 16:08:03, Punit Agrawal wrote: > Michal Hocko writes: [...] > > Well, the standard way to handle memory less NUMA nodes is to simply > > fallback to the closest NUMA node. We even have an API for that > > (numa_mem_id). > > CONFIG_HAVE_MEMORYLESS node is not enabled on arm64

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-12 Thread Michal Hocko
On Tue 12-06-18 16:08:03, Punit Agrawal wrote: > Michal Hocko writes: [...] > > Well, the standard way to handle memory less NUMA nodes is to simply > > fallback to the closest NUMA node. We even have an API for that > > (numa_mem_id). > > CONFIG_HAVE_MEMORYLESS node is not enabled on arm64

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-12 Thread Punit Agrawal
Michal Hocko writes: > On Mon 11-06-18 08:43:03, Bjorn Helgaas wrote: >> On Mon, Jun 11, 2018 at 08:32:10PM +0800, Xie XiuQi wrote: >> > Hi Michal, >> > >> > On 2018/6/11 16:52, Michal Hocko wrote: >> > > On Mon 11-06-18 11:23:18, Xie XiuQi wrote: >> > >> Hi Michal, >> > >> >> > >> On 2018/6/7

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-12 Thread Punit Agrawal
Michal Hocko writes: > On Mon 11-06-18 08:43:03, Bjorn Helgaas wrote: >> On Mon, Jun 11, 2018 at 08:32:10PM +0800, Xie XiuQi wrote: >> > Hi Michal, >> > >> > On 2018/6/11 16:52, Michal Hocko wrote: >> > > On Mon 11-06-18 11:23:18, Xie XiuQi wrote: >> > >> Hi Michal, >> > >> >> > >> On 2018/6/7

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-11 Thread Michal Hocko
On Mon 11-06-18 08:43:03, Bjorn Helgaas wrote: > On Mon, Jun 11, 2018 at 08:32:10PM +0800, Xie XiuQi wrote: > > Hi Michal, > > > > On 2018/6/11 16:52, Michal Hocko wrote: > > > On Mon 11-06-18 11:23:18, Xie XiuQi wrote: > > >> Hi Michal, > > >> > > >> On 2018/6/7 20:21, Michal Hocko wrote: > >

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-11 Thread Michal Hocko
On Mon 11-06-18 08:43:03, Bjorn Helgaas wrote: > On Mon, Jun 11, 2018 at 08:32:10PM +0800, Xie XiuQi wrote: > > Hi Michal, > > > > On 2018/6/11 16:52, Michal Hocko wrote: > > > On Mon 11-06-18 11:23:18, Xie XiuQi wrote: > > >> Hi Michal, > > >> > > >> On 2018/6/7 20:21, Michal Hocko wrote: > >

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-11 Thread Bjorn Helgaas
On Mon, Jun 11, 2018 at 08:32:10PM +0800, Xie XiuQi wrote: > Hi Michal, > > On 2018/6/11 16:52, Michal Hocko wrote: > > On Mon 11-06-18 11:23:18, Xie XiuQi wrote: > >> Hi Michal, > >> > >> On 2018/6/7 20:21, Michal Hocko wrote: > >>> On Thu 07-06-18 19:55:53, Hanjun Guo wrote: > On 2018/6/7

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-11 Thread Bjorn Helgaas
On Mon, Jun 11, 2018 at 08:32:10PM +0800, Xie XiuQi wrote: > Hi Michal, > > On 2018/6/11 16:52, Michal Hocko wrote: > > On Mon 11-06-18 11:23:18, Xie XiuQi wrote: > >> Hi Michal, > >> > >> On 2018/6/7 20:21, Michal Hocko wrote: > >>> On Thu 07-06-18 19:55:53, Hanjun Guo wrote: > On 2018/6/7

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-11 Thread Xie XiuQi
Hi Michal, On 2018/6/11 16:52, Michal Hocko wrote: > On Mon 11-06-18 11:23:18, Xie XiuQi wrote: >> Hi Michal, >> >> On 2018/6/7 20:21, Michal Hocko wrote: >>> On Thu 07-06-18 19:55:53, Hanjun Guo wrote: On 2018/6/7 18:55, Michal Hocko wrote: >>> [...] > I am not sure I have the full

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-11 Thread Xie XiuQi
Hi Michal, On 2018/6/11 16:52, Michal Hocko wrote: > On Mon 11-06-18 11:23:18, Xie XiuQi wrote: >> Hi Michal, >> >> On 2018/6/7 20:21, Michal Hocko wrote: >>> On Thu 07-06-18 19:55:53, Hanjun Guo wrote: On 2018/6/7 18:55, Michal Hocko wrote: >>> [...] > I am not sure I have the full

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-11 Thread Michal Hocko
On Mon 11-06-18 11:23:18, Xie XiuQi wrote: > Hi Michal, > > On 2018/6/7 20:21, Michal Hocko wrote: > > On Thu 07-06-18 19:55:53, Hanjun Guo wrote: > >> On 2018/6/7 18:55, Michal Hocko wrote: > > [...] > >>> I am not sure I have the full context but pci_acpi_scan_root calls > >>>

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-11 Thread Michal Hocko
On Mon 11-06-18 11:23:18, Xie XiuQi wrote: > Hi Michal, > > On 2018/6/7 20:21, Michal Hocko wrote: > > On Thu 07-06-18 19:55:53, Hanjun Guo wrote: > >> On 2018/6/7 18:55, Michal Hocko wrote: > > [...] > >>> I am not sure I have the full context but pci_acpi_scan_root calls > >>>

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-10 Thread Xie XiuQi
Hi Michal, On 2018/6/7 20:21, Michal Hocko wrote: > On Thu 07-06-18 19:55:53, Hanjun Guo wrote: >> On 2018/6/7 18:55, Michal Hocko wrote: > [...] >>> I am not sure I have the full context but pci_acpi_scan_root calls >>> kzalloc_node(sizeof(*info), GFP_KERNEL, node) >>> and that should fall back

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-10 Thread Xie XiuQi
Hi Michal, On 2018/6/7 20:21, Michal Hocko wrote: > On Thu 07-06-18 19:55:53, Hanjun Guo wrote: >> On 2018/6/7 18:55, Michal Hocko wrote: > [...] >>> I am not sure I have the full context but pci_acpi_scan_root calls >>> kzalloc_node(sizeof(*info), GFP_KERNEL, node) >>> and that should fall back

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-07 Thread Michal Hocko
On Thu 07-06-18 19:55:53, Hanjun Guo wrote: > On 2018/6/7 18:55, Michal Hocko wrote: [...] > > I am not sure I have the full context but pci_acpi_scan_root calls > > kzalloc_node(sizeof(*info), GFP_KERNEL, node) > > and that should fall back to whatever node that is online. Offline node > >

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-07 Thread Michal Hocko
On Thu 07-06-18 19:55:53, Hanjun Guo wrote: > On 2018/6/7 18:55, Michal Hocko wrote: [...] > > I am not sure I have the full context but pci_acpi_scan_root calls > > kzalloc_node(sizeof(*info), GFP_KERNEL, node) > > and that should fall back to whatever node that is online. Offline node > >

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-07 Thread Hanjun Guo
On 2018/6/7 18:55, Michal Hocko wrote: > On Wed 06-06-18 15:39:34, Bjorn Helgaas wrote: >> [+cc akpm, linux-mm, linux-pci] >> >> On Wed, Jun 6, 2018 at 10:44 AM Will Deacon wrote: >>> >>> On Thu, May 31, 2018 at 08:14:38PM +0800, Xie XiuQi wrote: A numa system may return node which is not

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-07 Thread Hanjun Guo
On 2018/6/7 18:55, Michal Hocko wrote: > On Wed 06-06-18 15:39:34, Bjorn Helgaas wrote: >> [+cc akpm, linux-mm, linux-pci] >> >> On Wed, Jun 6, 2018 at 10:44 AM Will Deacon wrote: >>> >>> On Thu, May 31, 2018 at 08:14:38PM +0800, Xie XiuQi wrote: A numa system may return node which is not

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-07 Thread Michal Hocko
On Wed 06-06-18 15:39:34, Bjorn Helgaas wrote: > [+cc akpm, linux-mm, linux-pci] > > On Wed, Jun 6, 2018 at 10:44 AM Will Deacon wrote: > > > > On Thu, May 31, 2018 at 08:14:38PM +0800, Xie XiuQi wrote: > > > A numa system may return node which is not online. > > > For example, a numa node: > >

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-07 Thread Michal Hocko
On Wed 06-06-18 15:39:34, Bjorn Helgaas wrote: > [+cc akpm, linux-mm, linux-pci] > > On Wed, Jun 6, 2018 at 10:44 AM Will Deacon wrote: > > > > On Thu, May 31, 2018 at 08:14:38PM +0800, Xie XiuQi wrote: > > > A numa system may return node which is not online. > > > For example, a numa node: > >

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-06 Thread Bjorn Helgaas
[+cc akpm, linux-mm, linux-pci] On Wed, Jun 6, 2018 at 10:44 AM Will Deacon wrote: > > On Thu, May 31, 2018 at 08:14:38PM +0800, Xie XiuQi wrote: > > A numa system may return node which is not online. > > For example, a numa node: > > 1) without memory > > 2) NR_CPUS is very small, and the cpus

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-06 Thread Bjorn Helgaas
[+cc akpm, linux-mm, linux-pci] On Wed, Jun 6, 2018 at 10:44 AM Will Deacon wrote: > > On Thu, May 31, 2018 at 08:14:38PM +0800, Xie XiuQi wrote: > > A numa system may return node which is not online. > > For example, a numa node: > > 1) without memory > > 2) NR_CPUS is very small, and the cpus

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-06 Thread Will Deacon
On Thu, May 31, 2018 at 08:14:38PM +0800, Xie XiuQi wrote: > A numa system may return node which is not online. > For example, a numa node: > 1) without memory > 2) NR_CPUS is very small, and the cpus on the node are not brought up > > In this situation, we use NUMA_NO_NODE to avoid oops. > > [

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-06 Thread Will Deacon
On Thu, May 31, 2018 at 08:14:38PM +0800, Xie XiuQi wrote: > A numa system may return node which is not online. > For example, a numa node: > 1) without memory > 2) NR_CPUS is very small, and the cpus on the node are not brought up > > In this situation, we use NUMA_NO_NODE to avoid oops. > > [

[PATCH 1/2] arm64: avoid alloc memory on offline node

2018-05-31 Thread Xie XiuQi
A numa system may return node which is not online. For example, a numa node: 1) without memory 2) NR_CPUS is very small, and the cpus on the node are not brought up In this situation, we use NUMA_NO_NODE to avoid oops. [ 25.732905] Unable to handle kernel NULL pointer dereference at virtual

[PATCH 1/2] arm64: avoid alloc memory on offline node

2018-05-31 Thread Xie XiuQi
A numa system may return node which is not online. For example, a numa node: 1) without memory 2) NR_CPUS is very small, and the cpus on the node are not brought up In this situation, we use NUMA_NO_NODE to avoid oops. [ 25.732905] Unable to handle kernel NULL pointer dereference at virtual