Re: [PATCH 1/2] asm-generic/io.h: provide default ioremap/iounmap for !HAS_IOMEM

2016-03-31 Thread Geert Uytterhoeven
Hi Rob, On Wed, Mar 30, 2016 at 11:20 PM, Rob Herring wrote: > On Wed, Mar 30, 2016 at 3:08 PM, Geert Uytterhoeven > wrote: >> On Tue, Mar 29, 2016 at 10:13 PM, Rob Herring wrote: >>> Ewww. Why do the opposite of what we do for every other Kconfig symbol >>> which is provide empty functions? It

Re: [PATCH 1/2] asm-generic/io.h: provide default ioremap/iounmap for !HAS_IOMEM

2016-03-30 Thread Rob Herring
On Wed, Mar 30, 2016 at 3:08 PM, Geert Uytterhoeven wrote: > Hi Rob, > > On Tue, Mar 29, 2016 at 10:13 PM, Rob Herring wrote: >> On Tue, Mar 29, 2016 at 2:37 PM, Arnd Bergmann wrote: >>> On Tuesday 29 March 2016 13:23:00 Rob Herring wrote: Drivers shouldn't have to care about HAS_IOMEM to c

Re: [PATCH 1/2] asm-generic/io.h: provide default ioremap/iounmap for !HAS_IOMEM

2016-03-30 Thread Arnd Bergmann
On Wednesday 30 March 2016 22:35:37 Richard Weinberger wrote: > Am 30.03.2016 um 22:08 schrieb Geert Uytterhoeven: > >> I actually started a patch to remove the HAS_IOMEM dependency > >> everywhere (or just the per driver cases). It didn't break as bad as I > >> expected, but became more than I wan

Re: [PATCH 1/2] asm-generic/io.h: provide default ioremap/iounmap for !HAS_IOMEM

2016-03-30 Thread Richard Weinberger
Am 30.03.2016 um 22:08 schrieb Geert Uytterhoeven: >> I actually started a patch to remove the HAS_IOMEM dependency >> everywhere (or just the per driver cases). It didn't break as bad as I >> expected, but became more than I wanted to fix. Mainly, all the devm_ >> variants also need empty versions

Re: [PATCH 1/2] asm-generic/io.h: provide default ioremap/iounmap for !HAS_IOMEM

2016-03-30 Thread Geert Uytterhoeven
Hi Rob, On Tue, Mar 29, 2016 at 10:13 PM, Rob Herring wrote: > On Tue, Mar 29, 2016 at 2:37 PM, Arnd Bergmann wrote: >> On Tuesday 29 March 2016 13:23:00 Rob Herring wrote: >>> Drivers shouldn't have to care about HAS_IOMEM to compile and having to >>> causes a Kconfig mess: >>> >>> warning: (ME

Re: [PATCH 1/2] asm-generic/io.h: provide default ioremap/iounmap for !HAS_IOMEM

2016-03-30 Thread Arnd Bergmann
On Wednesday 30 March 2016 08:29:45 Rob Herring wrote: > On Wed, Mar 30, 2016 at 5:03 AM, Arnd Bergmann wrote: > > On Wednesday 30 March 2016 10:13:53 Richard Weinberger wrote: > >> > >> I fully understand your point of view. COMPILE_TEST is a monster that > >> can do the heavy lifting for you, bu

Re: [PATCH 1/2] asm-generic/io.h: provide default ioremap/iounmap for !HAS_IOMEM

2016-03-30 Thread Rob Herring
On Wed, Mar 30, 2016 at 5:03 AM, Arnd Bergmann wrote: > On Wednesday 30 March 2016 10:13:53 Richard Weinberger wrote: >> >> I fully understand your point of view. COMPILE_TEST is a monster that >> can do the heavy lifting for you, but monsters also have claws and fangs. >> >> Having COMPILE_TEST h

Re: [PATCH 1/2] asm-generic/io.h: provide default ioremap/iounmap for !HAS_IOMEM

2016-03-30 Thread Arnd Bergmann
On Wednesday 30 March 2016 10:13:53 Richard Weinberger wrote: > > I fully understand your point of view. COMPILE_TEST is a monster that > can do the heavy lifting for you, but monsters also have claws and fangs. > > Having COMPILE_TEST having depend on !UML works for me. But don't > we have othe

Re: [PATCH 1/2] asm-generic/io.h: provide default ioremap/iounmap for !HAS_IOMEM

2016-03-30 Thread Richard Weinberger
Am 30.03.2016 um 10:04 schrieb Arnd Bergmann: > On Wednesday 30 March 2016 09:50:22 Richard Weinberger wrote: >> Am 29.03.2016 um 22:13 schrieb Rob Herring: > Reuse the !MMU variants for !HAS_IOMEM as they are sufficient for our > needs. This fixes build errors for UM allyesconfig: > >>

Re: [PATCH 1/2] asm-generic/io.h: provide default ioremap/iounmap for !HAS_IOMEM

2016-03-30 Thread Arnd Bergmann
On Wednesday 30 March 2016 09:50:22 Richard Weinberger wrote: > Am 29.03.2016 um 22:13 schrieb Rob Herring: > >>> Reuse the !MMU variants for !HAS_IOMEM as they are sufficient for our > >>> needs. This fixes build errors for UM allyesconfig: > >>> > >>> drivers/mfd/syscon.c:89:2: error: implicit de

Re: [PATCH 1/2] asm-generic/io.h: provide default ioremap/iounmap for !HAS_IOMEM

2016-03-30 Thread Richard Weinberger
Am 29.03.2016 um 22:13 schrieb Rob Herring: >>> Reuse the !MMU variants for !HAS_IOMEM as they are sufficient for our >>> needs. This fixes build errors for UM allyesconfig: >>> >>> drivers/mfd/syscon.c:89:2: error: implicit declaration of function >>> 'iounmap' [-Werror=implicit-function-declarat

Re: [PATCH 1/2] asm-generic/io.h: provide default ioremap/iounmap for !HAS_IOMEM

2016-03-29 Thread Krzysztof Kozlowski
On Wed, Mar 30, 2016 at 3:23 AM, Rob Herring wrote: > Drivers shouldn't have to care about HAS_IOMEM to compile and having to > causes a Kconfig mess: > > warning: (MEDIA_SUBDRV_AUTOSELECT && VIDEO_CX231XX && INV_MPU6050_I2C) > selects I2C_MUX which has unmet direct dependencies (I2C && HAS_IOMEM

Re: [PATCH 1/2] asm-generic/io.h: provide default ioremap/iounmap for !HAS_IOMEM

2016-03-29 Thread Rob Herring
On Tue, Mar 29, 2016 at 2:37 PM, Arnd Bergmann wrote: > On Tuesday 29 March 2016 13:23:00 Rob Herring wrote: >> Drivers shouldn't have to care about HAS_IOMEM to compile and having to >> causes a Kconfig mess: >> >> warning: (MEDIA_SUBDRV_AUTOSELECT && VIDEO_CX231XX && INV_MPU6050_I2C) >> selects

Re: [PATCH 1/2] asm-generic/io.h: provide default ioremap/iounmap for !HAS_IOMEM

2016-03-29 Thread Richard Weinberger
Am 29.03.2016 um 21:37 schrieb Arnd Bergmann: > On Tuesday 29 March 2016 13:23:00 Rob Herring wrote: >> Drivers shouldn't have to care about HAS_IOMEM to compile and having to >> causes a Kconfig mess: >> >> warning: (MEDIA_SUBDRV_AUTOSELECT && VIDEO_CX231XX && INV_MPU6050_I2C) >> selects I2C_MUX

Re: [PATCH 1/2] asm-generic/io.h: provide default ioremap/iounmap for !HAS_IOMEM

2016-03-29 Thread Arnd Bergmann
On Tuesday 29 March 2016 13:23:00 Rob Herring wrote: > Drivers shouldn't have to care about HAS_IOMEM to compile and having to > causes a Kconfig mess: > > warning: (MEDIA_SUBDRV_AUTOSELECT && VIDEO_CX231XX && INV_MPU6050_I2C) > selects I2C_MUX which has unmet direct dependencies (I2C && HAS_IOME

[PATCH 1/2] asm-generic/io.h: provide default ioremap/iounmap for !HAS_IOMEM

2016-03-29 Thread Rob Herring
Drivers shouldn't have to care about HAS_IOMEM to compile and having to causes a Kconfig mess: warning: (MEDIA_SUBDRV_AUTOSELECT && VIDEO_CX231XX && INV_MPU6050_I2C) selects I2C_MUX which has unmet direct dependencies (I2C && HAS_IOMEM) warning: (ST_IRQCHIP && STMMAC_PLATFORM && DWMAC_IPQ806X &&