Re: [PATCH 1/2] ata: delete redundant printing of return value

2021-03-13 Thread Hans de Goede
Hi, On 3/13/21 8:46 AM, Wang Qing wrote: > platform_get_irq() has already checked and printed the return value, > the printing here is nothing special, it is not necessary at all. > > Signed-off-by: Wang Qing Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > ---

Re: [PATCH 1/2] ata: delete redundant printing of return value

2021-03-13 Thread Sergei Shtylyov
Hello again. :-) Now, 2 patches to the different files shouldn't have and identical subject! And the patch subject should reflect the exact patch locus, e.g. "sata_highbank: delete redundant printing of return value". On 3/13/21 10:47 AM, Wang Qing wrote: > platform_get_irq() has already

Re: [PATCH 1/2] ata: delete redundant printing of return value

2021-03-13 Thread Sergei Shtylyov
Hello! The patch subject should reflect the exact patch locus, e.g. "ata: libahci_platform: delete redundant printing of return value". On 3/13/21 10:46 AM, Wang Qing wrote: > platform_get_irq() has already checked and printed the return value, > the printing here is nothing special, it is

[PATCH 1/2] ata: delete redundant printing of return value

2021-03-12 Thread Wang Qing
platform_get_irq() has already checked and printed the return value, the printing here is nothing special, it is not necessary at all. Signed-off-by: Wang Qing --- drivers/ata/sata_highbank.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/ata/sata_highbank.c

[PATCH 1/2] ata: delete redundant printing of return value

2021-03-12 Thread Wang Qing
platform_get_irq() has already checked and printed the return value, the printing here is nothing special, it is not necessary at all. Signed-off-by: Wang Qing --- drivers/ata/libahci_platform.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git