Re: [PATCH 1/2] auxdisplay: HD44780 connected to I2C via PCF8574

2021-01-06 Thread Ralf Schlatterbeck
Miguel, Geert, thanks for the quick feedback. On Wed, Jan 06, 2021 at 09:03:13AM +0100, Geert Uytterhoeven wrote: > > Unless I'm missing some little detail, there should be no need for this > driver: this wiring (and alternative wirings) can just be expressed in DT. > Examples (using 74HC595 SPI

Re: [PATCH 1/2] auxdisplay: HD44780 connected to I2C via PCF8574

2021-01-06 Thread Geert Uytterhoeven
Hi Ralf, On Wed, Jan 6, 2021 at 3:42 AM Miguel Ojeda wrote: > On Tue, Jan 5, 2021 at 4:04 PM Ralf Schlatterbeck wrote: > > Add HD44780 character display connected via I2C I/O expander. > > Re-uses the high-level interface of the existing HD44780 driver. > > > > Signed-off-by: Ralf Schlatterbeck

Re: [PATCH 1/2] auxdisplay: HD44780 connected to I2C via PCF8574

2021-01-05 Thread Miguel Ojeda
Hi Ralf, On Tue, Jan 5, 2021 at 4:04 PM Ralf Schlatterbeck wrote: > > Add HD44780 character display connected via I2C I/O expander. > Re-uses the high-level interface of the existing HD44780 driver. > > Signed-off-by: Ralf Schlatterbeck Thanks for the driver! See a first quick review below.

[PATCH 1/2] auxdisplay: HD44780 connected to I2C via PCF8574

2021-01-05 Thread Ralf Schlatterbeck
Add HD44780 character display connected via I2C I/O expander. Re-uses the high-level interface of the existing HD44780 driver. Signed-off-by: Ralf Schlatterbeck --- drivers/auxdisplay/Kconfig | 14 +- drivers/auxdisplay/Makefile | 1 + drivers/auxdisplay/hd44780-pcf8574.c