Re: [PATCH 1/2] cgroup: fix exit() vsrmdir() race

2013-01-24 Thread Tejun Heo
On Thu, Jan 24, 2013 at 10:19:23AM -0800, Tejun Heo wrote: > * cgroup_release_agent() seems broken too. It's accessing cgrp after > removing it from release_list. Can you please fix it too? Oh, we should be okay as we're holding cgroup_mutex there. Please forget about the above. Thanks. --

Re: [PATCH 1/2] cgroup: fix exit() vsrmdir() race

2013-01-24 Thread Tejun Heo
On Thu, Jan 24, 2013 at 02:43:28PM +0800, Li Zefan wrote: > In cgroup_exit() put_css_set_taskexit() is called without any lock, > which might lead to accessing a freed cgroup: > > thread1 thread2 > - > exit() > cgroup_exit() >

[PATCH 1/2] cgroup: fix exit() vsrmdir() race

2013-01-23 Thread Li Zefan
In cgroup_exit() put_css_set_taskexit() is called without any lock, which might lead to accessing a freed cgroup: thread1 thread2 - exit() cgroup_exit() put_css_set_taskexit() atomic_dec(cgrp->count);