Re: [PATCH 1/2] clk: Add Oxford Semiconductor OXNAS Standard Clocks

2016-04-11 Thread Stephen Boyd
On 04/11, Neil Armstrong wrote: > On 04/08/2016 01:31 AM, Stephen Boyd wrote: > > On 04/03, Neil Armstrong wrote: > >> On 04/02/2016 02:50 AM, Stephen Boyd wrote: > > > > Ok. I was hoping that we could make simple-mfd look to see if > > there's a syscon and then attach it to the parent device,

Re: [PATCH 1/2] clk: Add Oxford Semiconductor OXNAS Standard Clocks

2016-04-11 Thread Stephen Boyd
On 04/11, Neil Armstrong wrote: > On 04/08/2016 01:31 AM, Stephen Boyd wrote: > > On 04/03, Neil Armstrong wrote: > >> On 04/02/2016 02:50 AM, Stephen Boyd wrote: > > > > Ok. I was hoping that we could make simple-mfd look to see if > > there's a syscon and then attach it to the parent device,

Re: [PATCH 1/2] clk: Add Oxford Semiconductor OXNAS Standard Clocks

2016-04-11 Thread Neil Armstrong
On 04/08/2016 01:31 AM, Stephen Boyd wrote: > On 04/03, Neil Armstrong wrote: >> On 04/02/2016 02:50 AM, Stephen Boyd wrote: > > Ok. I was hoping that we could make simple-mfd look to see if > there's a syscon and then attach it to the parent device, but it > seems that simple-mfd is not actually

Re: [PATCH 1/2] clk: Add Oxford Semiconductor OXNAS Standard Clocks

2016-04-11 Thread Neil Armstrong
On 04/08/2016 01:31 AM, Stephen Boyd wrote: > On 04/03, Neil Armstrong wrote: >> On 04/02/2016 02:50 AM, Stephen Boyd wrote: > > Ok. I was hoping that we could make simple-mfd look to see if > there's a syscon and then attach it to the parent device, but it > seems that simple-mfd is not actually

Re: [PATCH 1/2] clk: Add Oxford Semiconductor OXNAS Standard Clocks

2016-04-07 Thread Stephen Boyd
On 04/03, Neil Armstrong wrote: > On 04/02/2016 02:50 AM, Stephen Boyd wrote: > > On 04/01, Neil Armstrong wrote: > >> + if (!onecell_data) > >> + return -ENOMEM; > >> + > >> + regmap = syscon_node_to_regmap(of_get_parent(np)); > > > > Can we use dev_get_regmap(>dev.parent) here

Re: [PATCH 1/2] clk: Add Oxford Semiconductor OXNAS Standard Clocks

2016-04-07 Thread Stephen Boyd
On 04/03, Neil Armstrong wrote: > On 04/02/2016 02:50 AM, Stephen Boyd wrote: > > On 04/01, Neil Armstrong wrote: > >> + if (!onecell_data) > >> + return -ENOMEM; > >> + > >> + regmap = syscon_node_to_regmap(of_get_parent(np)); > > > > Can we use dev_get_regmap(>dev.parent) here

Re: [PATCH 1/2] clk: Add Oxford Semiconductor OXNAS Standard Clocks

2016-04-03 Thread Neil Armstrong
On 04/02/2016 02:50 AM, Stephen Boyd wrote: > On 04/01, Neil Armstrong wrote: >> +if (!onecell_data) >> +return -ENOMEM; >> + >> +regmap = syscon_node_to_regmap(of_get_parent(np)); > > Can we use dev_get_regmap(>dev.parent) here instead? I'd > prefer device APIs over DT APIs

Re: [PATCH 1/2] clk: Add Oxford Semiconductor OXNAS Standard Clocks

2016-04-03 Thread Neil Armstrong
On 04/02/2016 02:50 AM, Stephen Boyd wrote: > On 04/01, Neil Armstrong wrote: >> +if (!onecell_data) >> +return -ENOMEM; >> + >> +regmap = syscon_node_to_regmap(of_get_parent(np)); > > Can we use dev_get_regmap(>dev.parent) here instead? I'd > prefer device APIs over DT APIs

Re: [PATCH 1/2] clk: Add Oxford Semiconductor OXNAS Standard Clocks

2016-04-02 Thread Neil Armstrong
On 04/02/2016 02:50 AM, Stephen Boyd wrote: >> + >> +/* Bit - Name association */ >> +static const struct clk_init_data *clk_oxnas_init[] = { >> +[0] = _leon_init, >> +[1] = _dma_sgdma_init, >> +[2] = _cipher_init, >> +[3] = NULL, /* Do not touch to DDR clock */ > >

Re: [PATCH 1/2] clk: Add Oxford Semiconductor OXNAS Standard Clocks

2016-04-02 Thread Neil Armstrong
On 04/02/2016 02:50 AM, Stephen Boyd wrote: >> + >> +/* Bit - Name association */ >> +static const struct clk_init_data *clk_oxnas_init[] = { >> +[0] = _leon_init, >> +[1] = _dma_sgdma_init, >> +[2] = _cipher_init, >> +[3] = NULL, /* Do not touch to DDR clock */ > >

Re: [PATCH 1/2] clk: Add Oxford Semiconductor OXNAS Standard Clocks

2016-04-01 Thread Stephen Boyd
On 04/01, Neil Armstrong wrote: > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > index 16f7d33..2efdbab 100644 > --- a/drivers/clk/Kconfig > +++ b/drivers/clk/Kconfig > @@ -197,6 +197,12 @@ config COMMON_CLK_PXA > ---help--- > Support for the Marvell PXA SoC. > > +config

Re: [PATCH 1/2] clk: Add Oxford Semiconductor OXNAS Standard Clocks

2016-04-01 Thread Stephen Boyd
On 04/01, Neil Armstrong wrote: > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > index 16f7d33..2efdbab 100644 > --- a/drivers/clk/Kconfig > +++ b/drivers/clk/Kconfig > @@ -197,6 +197,12 @@ config COMMON_CLK_PXA > ---help--- > Support for the Marvell PXA SoC. > > +config

[PATCH 1/2] clk: Add Oxford Semiconductor OXNAS Standard Clocks

2016-04-01 Thread Neil Armstrong
Add Oxford Semiconductor OXNAS SoC Family Standard Clocks support. Signed-off-by: Neil Armstrong --- drivers/clk/Kconfig | 6 ++ drivers/clk/Makefile| 1 + drivers/clk/clk-oxnas.c | 202 3 files changed, 209

[PATCH 1/2] clk: Add Oxford Semiconductor OXNAS Standard Clocks

2016-04-01 Thread Neil Armstrong
Add Oxford Semiconductor OXNAS SoC Family Standard Clocks support. Signed-off-by: Neil Armstrong --- drivers/clk/Kconfig | 6 ++ drivers/clk/Makefile| 1 + drivers/clk/clk-oxnas.c | 202 3 files changed, 209 insertions(+) create mode