> > case CLOCK_EVT_MODE_RESUME:
> > return dev->setup_resume(dev);
>
> Because setting to all these existing modes isn't allowed
> to fail currently, shouldn't we make return type of all the new
> callbacks as 'void' and return 0 from this routine ? That way, these
>
Hi Thomas,
On 23 January 2015 at 17:27, Thomas Gleixner wrote:
> static int __clockevents_set_mode(dev, mode)
> {
> /* Transition mode */
> if (dev->set_mode) {
>if (mode > CLOCK_EVT_MODE_RESUME)
> return -ENOSYS;
>dev->set_mode(mode,
case CLOCK_EVT_MODE_RESUME:
return dev-setup_resume(dev);
Because setting to all these existing modes isn't allowed
to fail currently, shouldn't we make return type of all the new
callbacks as 'void' and return 0 from this routine ? That way, these
callbacks would
Hi Thomas,
On 23 January 2015 at 17:27, Thomas Gleixner t...@linutronix.de wrote:
static int __clockevents_set_mode(dev, mode)
{
/* Transition mode */
if (dev-set_mode) {
if (mode CLOCK_EVT_MODE_RESUME)
return -ENOSYS;
On Tue, 9 Dec 2014, Kevin Hilman wrote:
> diff --git a/kernel/time/clockevents.c b/kernel/time/clockevents.c
> index 55449909f114..f7614041240e 100644
> --- a/kernel/time/clockevents.c
> +++ b/kernel/time/clockevents.c
> @@ -105,7 +105,16 @@ void clockevents_set_mode(struct clock_event_device
On Tue, 9 Dec 2014, Kevin Hilman wrote:
diff --git a/kernel/time/clockevents.c b/kernel/time/clockevents.c
index 55449909f114..f7614041240e 100644
--- a/kernel/time/clockevents.c
+++ b/kernel/time/clockevents.c
@@ -105,7 +105,16 @@ void clockevents_set_mode(struct clock_event_device *dev,
On 12/10/2014 03:33 AM, Kevin Hilman wrote:
> From: Viresh Kumar
>
> Currently, the ->set_mode() method of a clockevent device is not
> allowed to fail, so it has no return value. In order to add new
> clockevent modes, and allow the setting of those modes to fail, we
> need the clockevent core
From: Viresh Kumar
Currently, the ->set_mode() method of a clockevent device is not
allowed to fail, so it has no return value. In order to add new
clockevent modes, and allow the setting of those modes to fail, we
need the clockevent core to be able to detect when setting a mode
fails.
To
From: Viresh Kumar viresh.ku...@linaro.org
Currently, the -set_mode() method of a clockevent device is not
allowed to fail, so it has no return value. In order to add new
clockevent modes, and allow the setting of those modes to fail, we
need the clockevent core to be able to detect when setting
On 12/10/2014 03:33 AM, Kevin Hilman wrote:
From: Viresh Kumar viresh.ku...@linaro.org
Currently, the -set_mode() method of a clockevent device is not
allowed to fail, so it has no return value. In order to add new
clockevent modes, and allow the setting of those modes to fail, we
need the
This looks good to me.
On 11/20/2014 12:09 AM, Kevin Hilman wrote:
> From: Viresh Kumar
>
> Currently, the ->set_mode() method of a clockevent device is not
> allowed to fail, so it has no return value. In order to add new
> clockevent modes, and allow the setting of those modes to fail, we
>
From: Viresh Kumar
Currently, the ->set_mode() method of a clockevent device is not
allowed to fail, so it has no return value. In order to add new
clockevent modes, and allow the setting of those modes to fail, we
need the clockevent core to be able to detect when setting a mode
fails.
To
From: Viresh Kumar viresh.ku...@linaro.org
Currently, the -set_mode() method of a clockevent device is not
allowed to fail, so it has no return value. In order to add new
clockevent modes, and allow the setting of those modes to fail, we
need the clockevent core to be able to detect when setting
This looks good to me.
On 11/20/2014 12:09 AM, Kevin Hilman wrote:
From: Viresh Kumar viresh.ku...@linaro.org
Currently, the -set_mode() method of a clockevent device is not
allowed to fail, so it has no return value. In order to add new
clockevent modes, and allow the setting of those
From: Viresh Kumar
Currently, the ->set_mode() method of a clockevent device is not
allowed to fail, so it has no return value. In order to add new
clockevent modes, and allow the setting of those modes to fail, we
need the clockevent core to be able to detect when setting a mode
fails.
To
From: Viresh Kumar viresh.ku...@linaro.org
Currently, the -set_mode() method of a clockevent device is not
allowed to fail, so it has no return value. In order to add new
clockevent modes, and allow the setting of those modes to fail, we
need the clockevent core to be able to detect when setting
16 matches
Mail list logo
