Re: [PATCH 1/2] clone3: add CLONE3_CLEAR_SIGHAND

2019-10-14 Thread Christian Brauner
On Sat, Oct 12, 2019 at 01:46:54PM +0200, Michael Kerrisk (man-pages) wrote: > On 10/12/19 9:48 AM, Christian Brauner wrote: > > On Sat, Oct 12, 2019 at 08:53:34AM +0200, Michael Kerrisk (man-pages) wrote: > >> Hello Aleksa, > >> > >> On Sat, 12 Oct 2019 at 00:12, Aleksa Sarai wrote: > >>> > >>>

Re: [PATCH 1/2] clone3: add CLONE3_CLEAR_SIGHAND

2019-10-12 Thread Michael Kerrisk (man-pages)
On 10/12/19 9:48 AM, Christian Brauner wrote: > On Sat, Oct 12, 2019 at 08:53:34AM +0200, Michael Kerrisk (man-pages) wrote: >> Hello Aleksa, >> >> On Sat, 12 Oct 2019 at 00:12, Aleksa Sarai wrote: >>> >>> On 2019-10-11, Michael Kerrisk wrote: Why CLONE3_CLEAR_SIGHAND rather than just

Re: [PATCH 1/2] clone3: add CLONE3_CLEAR_SIGHAND

2019-10-12 Thread Christian Brauner
On Sat, Oct 12, 2019 at 08:53:34AM +0200, Michael Kerrisk (man-pages) wrote: > Hello Aleksa, > > On Sat, 12 Oct 2019 at 00:12, Aleksa Sarai wrote: > > > > On 2019-10-11, Michael Kerrisk wrote: > > > Why CLONE3_CLEAR_SIGHAND rather than just CLONE_CLEAR_SIGHAND? I don't care much how we name

Re: [PATCH 1/2] clone3: add CLONE3_CLEAR_SIGHAND

2019-10-12 Thread Michael Kerrisk (man-pages)
Hello Aleksa, On Sat, 12 Oct 2019 at 00:12, Aleksa Sarai wrote: > > On 2019-10-11, Michael Kerrisk wrote: > > Why CLONE3_CLEAR_SIGHAND rather than just CLONE_CLEAR_SIGHAND? > > There are no more flag bits left for the classic clone()/clone2() (the > last one was used up by CLONE_PIDFD) -- thus

Re: [PATCH 1/2] clone3: add CLONE3_CLEAR_SIGHAND

2019-10-11 Thread Aleksa Sarai
On 2019-10-11, Michael Kerrisk wrote: > Why CLONE3_CLEAR_SIGHAND rather than just CLONE_CLEAR_SIGHAND? There are no more flag bits left for the classic clone()/clone2() (the last one was used up by CLONE_PIDFD) -- thus this flag is clone3()-only. -- Aleksa Sarai Senior Software Engineer

Re: [PATCH 1/2] clone3: add CLONE3_CLEAR_SIGHAND

2019-10-11 Thread Michael Kerrisk
Hello Christian, Why CLONE3_CLEAR_SIGHAND rather than just CLONE_CLEAR_SIGHAND? Thanks, Michael

Re: [PATCH 1/2] clone3: add CLONE3_CLEAR_SIGHAND

2019-10-11 Thread Christian Brauner
On Fri, Oct 11, 2019 at 10:21:18AM +0200, Michal Hocko wrote: > [Cc linux-api] Right, thanks Michal. Christian

Re: [PATCH 1/2] clone3: add CLONE3_CLEAR_SIGHAND

2019-10-11 Thread Michal Hocko
[Cc linux-api] On Thu 10-10-19 15:35:17, Christian Brauner wrote: > Reset all signal handlers of the child not set to SIG_IGN to SIG_DFL. > Mutually exclusive with CLONE_SIGHAND to not disturb other thread's > signal handler. > > In the spirit of closer cooperation between glibc developers and

Re: [PATCH 1/2] clone3: add CLONE3_CLEAR_SIGHAND

2019-10-10 Thread Florian Weimer
* Christian Brauner: > On Thu, Oct 10, 2019 at 04:19:44PM +0200, Florian Weimer wrote: >> * Christian Brauner: >> >> > @@ -2567,7 +2572,7 @@ static bool clone3_args_valid(const struct >> > kernel_clone_args *kargs) >> > * All lower bits of the flag word are taken. >> > * Verify that no

Re: [PATCH 1/2] clone3: add CLONE3_CLEAR_SIGHAND

2019-10-10 Thread Christian Brauner
On Thu, Oct 10, 2019 at 04:19:44PM +0200, Florian Weimer wrote: > * Christian Brauner: > > > @@ -2567,7 +2572,7 @@ static bool clone3_args_valid(const struct > > kernel_clone_args *kargs) > > * All lower bits of the flag word are taken. > > * Verify that no other unknown flags are

Re: [PATCH 1/2] clone3: add CLONE3_CLEAR_SIGHAND

2019-10-10 Thread Florian Weimer
* Christian Brauner: > @@ -2567,7 +2572,7 @@ static bool clone3_args_valid(const struct > kernel_clone_args *kargs) >* All lower bits of the flag word are taken. >* Verify that no other unknown flags are passed along. >*/ > - if (kargs->flags & ~CLONE_LEGACY_FLAGS) >

[PATCH 1/2] clone3: add CLONE3_CLEAR_SIGHAND

2019-10-10 Thread Christian Brauner
Reset all signal handlers of the child not set to SIG_IGN to SIG_DFL. Mutually exclusive with CLONE_SIGHAND to not disturb other thread's signal handler. In the spirit of closer cooperation between glibc developers and kernel developers (cf. [2]) this patchset came out of a discussion on the