Re: [PATCH 1/2] cpufreq: mediatek: Add MT8173 cpufreq driver

2015-05-07 Thread Pi-Cheng Chen
On Fri, Apr 24, 2015 at 8:55 PM, Sascha Hauer wrote: > On Fri, Apr 24, 2015 at 02:46:25PM +0800, Pi-Cheng Chen wrote: >> Hi Sascha, >> >> Thanks for reviewing. >> >> On Thu, Apr 23, 2015 at 8:01 PM, Sascha Hauer wrote: >> > On Mon, Apr 20, 2015 at 05:27:26PM +0800, pi-cheng.chen wrote: >> >> This

Re: [PATCH 1/2] cpufreq: mediatek: Add MT8173 cpufreq driver

2015-05-07 Thread Pi-Cheng Chen
On Thu, Apr 30, 2015 at 3:42 PM, Sascha Hauer wrote: > On Mon, Apr 20, 2015 at 05:27:26PM +0800, pi-cheng.chen wrote: >> This patch implements MT8173 specific cpufreq driver with OPP table defined >> in the driver code. >> >> Signed-off-by: pi-cheng.chen >> --- >> drivers/cpufreq/Kconfig.arm

Re: [PATCH 1/2] cpufreq: mediatek: Add MT8173 cpufreq driver

2015-04-30 Thread Sascha Hauer
On Mon, Apr 20, 2015 at 05:27:26PM +0800, pi-cheng.chen wrote: > This patch implements MT8173 specific cpufreq driver with OPP table defined > in the driver code. > > Signed-off-by: pi-cheng.chen > --- > drivers/cpufreq/Kconfig.arm | 6 + > drivers/cpufreq/Makefile | 1 + > driv

Re: [PATCH 1/2] cpufreq: mediatek: Add MT8173 cpufreq driver

2015-04-28 Thread Viresh Kumar
On 24 April 2015 at 12:20, Pi-Cheng Chen wrote: > So even we have a new OPP binding to describe the OPP, we have to > leave these table as they are for backward compatibility? Yes. I could find the below excerpts from [1]: "The compatibility rules say that new kernels must work with older devic

Re: [PATCH 1/2] cpufreq: mediatek: Add MT8173 cpufreq driver

2015-04-24 Thread Sascha Hauer
On Fri, Apr 24, 2015 at 02:46:25PM +0800, Pi-Cheng Chen wrote: > Hi Sascha, > > Thanks for reviewing. > > On Thu, Apr 23, 2015 at 8:01 PM, Sascha Hauer wrote: > > On Mon, Apr 20, 2015 at 05:27:26PM +0800, pi-cheng.chen wrote: > >> This patch implements MT8173 specific cpufreq driver with OPP tab

Re: [PATCH 1/2] cpufreq: mediatek: Add MT8173 cpufreq driver

2015-04-23 Thread Pi-Cheng Chen
On Thu, Apr 23, 2015 at 8:56 PM, Mark Rutland wrote: >> +/* >> + * This is a temporary solution until we have new OPPv2 bindings. Therefore >> we >> + * could describe the OPPs with (freq, volt, volt) tuple properly in device >> + * tree. >> + */ >> + >> +/* OPP table for LITTLE cores of MT8173 *

Re: [PATCH 1/2] cpufreq: mediatek: Add MT8173 cpufreq driver

2015-04-23 Thread Pi-Cheng Chen
Hi Sascha, Thanks for reviewing. On Thu, Apr 23, 2015 at 8:01 PM, Sascha Hauer wrote: > On Mon, Apr 20, 2015 at 05:27:26PM +0800, pi-cheng.chen wrote: >> This patch implements MT8173 specific cpufreq driver with OPP table defined >> in the driver code. >> >> Signed-off-by: pi-cheng.chen >> ---

Re: [PATCH 1/2] cpufreq: mediatek: Add MT8173 cpufreq driver

2015-04-23 Thread Mark Rutland
> +/* > + * This is a temporary solution until we have new OPPv2 bindings. Therefore > we > + * could describe the OPPs with (freq, volt, volt) tuple properly in device > + * tree. > + */ > + > +/* OPP table for LITTLE cores of MT8173 */ > +struct mtk_cpu_opp mt8173_l_opp[] = { > + OPP(50700

Re: [PATCH 1/2] cpufreq: mediatek: Add MT8173 cpufreq driver

2015-04-23 Thread Sascha Hauer
On Mon, Apr 20, 2015 at 05:27:26PM +0800, pi-cheng.chen wrote: > This patch implements MT8173 specific cpufreq driver with OPP table defined > in the driver code. > > Signed-off-by: pi-cheng.chen > --- > drivers/cpufreq/Kconfig.arm | 6 + > drivers/cpufreq/Makefile | 1 + > driv

Re: [PATCH 1/2] cpufreq: mediatek: Add MT8173 cpufreq driver

2015-04-22 Thread Josh Cartwright
On Wed, Apr 22, 2015 at 11:11:34AM +0800, Pi-Cheng Chen wrote: [..] > >> +config ARM_MT8173_CPUFREQ > >> + bool "Mediatek MT8173 CPUFreq support" > >> + depends on ARCH_MEDIATEK && REGULATOR > > > > I think you want to 'select REGULATOR' here; because REGULATOR isn't > > a user-visible opti

Re: [PATCH 1/2] cpufreq: mediatek: Add MT8173 cpufreq driver

2015-04-21 Thread Pi-Cheng Chen
On Tue, Apr 21, 2015 at 2:28 AM, Paul Bolle wrote: > On Mon, 2015-04-20 at 17:27 +0800, pi-cheng.chen wrote: >> --- a/drivers/cpufreq/Kconfig.arm >> +++ b/drivers/cpufreq/Kconfig.arm > >> +config ARM_MT8173_CPUFREQ >> + bool "Mediatek MT8173 CPUFreq support" >> + depends on ARCH_MEDIATEK &

Re: [PATCH 1/2] cpufreq: mediatek: Add MT8173 cpufreq driver

2015-04-21 Thread Pi-Cheng Chen
Hi Josh, Thanks for reviewing. On Mon, Apr 20, 2015 at 10:17 PM, Josh Cartwright wrote: > On Mon, Apr 20, 2015 at 05:27:26PM +0800, pi-cheng.chen wrote: >> This patch implements MT8173 specific cpufreq driver with OPP table defined >> in the driver code. >> >> Signed-off-by: pi-cheng.chen >> --

Re: [PATCH 1/2] cpufreq: mediatek: Add MT8173 cpufreq driver

2015-04-20 Thread Paul Bolle
On Mon, 2015-04-20 at 09:17 -0500, Josh Cartwright wrote: > On Mon, Apr 20, 2015 at 05:27:26PM +0800, pi-cheng.chen wrote: > > --- a/drivers/cpufreq/Kconfig.arm > > +++ b/drivers/cpufreq/Kconfig.arm > > > +config ARM_MT8173_CPUFREQ > > + bool "Mediatek MT8173 CPUFreq support" > > + depends o

Re: [PATCH 1/2] cpufreq: mediatek: Add MT8173 cpufreq driver

2015-04-20 Thread Paul Bolle
On Mon, 2015-04-20 at 17:27 +0800, pi-cheng.chen wrote: > --- a/drivers/cpufreq/Kconfig.arm > +++ b/drivers/cpufreq/Kconfig.arm > +config ARM_MT8173_CPUFREQ > + bool "Mediatek MT8173 CPUFreq support" > + depends on ARCH_MEDIATEK && REGULATOR > + help > + This adds the CPUFreq dr

Re: [PATCH 1/2] cpufreq: mediatek: Add MT8173 cpufreq driver

2015-04-20 Thread Josh Cartwright
On Mon, Apr 20, 2015 at 05:27:26PM +0800, pi-cheng.chen wrote: > This patch implements MT8173 specific cpufreq driver with OPP table defined > in the driver code. > > Signed-off-by: pi-cheng.chen > --- > drivers/cpufreq/Kconfig.arm | 6 + > drivers/cpufreq/Makefile | 1 + > driv

[PATCH 1/2] cpufreq: mediatek: Add MT8173 cpufreq driver

2015-04-20 Thread pi-cheng.chen
This patch implements MT8173 specific cpufreq driver with OPP table defined in the driver code. Signed-off-by: pi-cheng.chen --- drivers/cpufreq/Kconfig.arm | 6 + drivers/cpufreq/Makefile | 1 + drivers/cpufreq/mt8173-cpufreq.c | 509 +++ 3 f