Re: [PATCH 1/2] dl2k: Add support for IP1000A-based cards

2015-11-15 Thread David Miller
From: Ondrej Zary Date: Sun, 15 Nov 2015 21:04:58 +0100 > Tested it with D-Link DGE-550T (chip marked DL-2000, probably > rebranded TC9020) and it works fine. Even the TC9020 datasheet > says: "Access Rule: Word, Double Word". So it was always wrong but > worked anyway. Great, thanks for the in

Re: [PATCH 1/2] dl2k: Add support for IP1000A-based cards

2015-11-15 Thread Ondrej Zary
On Sunday 15 November 2015 18:59:05 David Miller wrote: > From: Andy Shevchenko > Date: Sun, 15 Nov 2015 04:30:25 +0200 > > > On Sun, Nov 15, 2015 at 12:05 AM, Ondrej Zary > > > >> @@ -433,9 +474,10 @@ rio_open (struct net_device *dev) > >> > >> alloc_list (dev); > >> > >> - /* Get s

Re: [PATCH 1/2] dl2k: Add support for IP1000A-based cards

2015-11-15 Thread David Miller
From: Andy Shevchenko Date: Sun, 15 Nov 2015 04:30:25 +0200 > On Sun, Nov 15, 2015 at 12:05 AM, Ondrej Zary >> @@ -433,9 +474,10 @@ rio_open (struct net_device *dev) >> >> alloc_list (dev); >> >> - /* Get station address */ >> - for (i = 0; i < 6; i++) >> - dw8(S

Re: [PATCH 1/2] dl2k: Add support for IP1000A-based cards

2015-11-15 Thread Ondrej Zary
On Sunday 15 November 2015 03:30:25 Andy Shevchenko wrote: > On Sun, Nov 15, 2015 at 12:05 AM, Ondrej Zary > > wrote: > > Add support for IP1000A chips to dl2k driver. > > IP1000A chip looks like a TC9020 with integrated PHY. > > > > This allows IP1000A chips to work reliably because the ipg dri

Re: [PATCH 1/2] dl2k: Add support for IP1000A-based cards

2015-11-14 Thread Andy Shevchenko
On Sun, Nov 15, 2015 at 12:05 AM, Ondrej Zary wrote: > Add support for IP1000A chips to dl2k driver. > IP1000A chip looks like a TC9020 with integrated PHY. > > This allows IP1000A chips to work reliably because the ipg driver is > buggy - it loses packets under load and then completely stops > tr

[PATCH 1/2] dl2k: Add support for IP1000A-based cards

2015-11-14 Thread Ondrej Zary
Add support for IP1000A chips to dl2k driver. IP1000A chip looks like a TC9020 with integrated PHY. This allows IP1000A chips to work reliably because the ipg driver is buggy - it loses packets under load and then completely stops transmitting data. Tested with Asus NX1101 v2.0 at 10, 100 and 100

Re: [RFC, RFT PATCH 1/2] dl2k: Add support for IP1000A-based cards

2015-09-04 Thread Ondrej Zary
On Tuesday 25 August 2015 23:26:13 Ondrej Zary wrote: > On Tuesday 25 August 2015 23:04:30 David Miller wrote: > > From: Ondrej Zary > > Date: Sun, 23 Aug 2015 23:06:27 +0200 > > > > > Add support for IP1000A chips to dl2k driver. > > > IP1000A chip looks like a TC9020 with integrated PHY. > > > >

Re: [RFC, RFT PATCH 1/2] dl2k: Add support for IP1000A-based cards

2015-08-25 Thread Francois Romieu
Ondrej Zary : [...] > Actually, gigabit works with this patch. The "PHY magic" part contains > mii_write(9, 0x0700) which makes gigabit work. It'd be extatic if you could set mii->supports_gmii for the appropriate PHY so that dl2k.c::rio_get_settings returns sensible gigabit status (note: neithe

Re: [RFC, RFT PATCH 1/2] dl2k: Add support for IP1000A-based cards

2015-08-25 Thread Ondrej Zary
On Tuesday 25 August 2015 23:04:30 David Miller wrote: > From: Ondrej Zary > Date: Sun, 23 Aug 2015 23:06:27 +0200 > > > Add support for IP1000A chips to dl2k driver. > > IP1000A chip looks like a TC9020 with integrated PHY. > > > > Tested with Asus NX1101. > > You're saying the PHY support is inc

Re: [RFC, RFT PATCH 1/2] dl2k: Add support for IP1000A-based cards

2015-08-25 Thread David Miller
From: Ondrej Zary Date: Sun, 23 Aug 2015 23:06:27 +0200 > Add support for IP1000A chips to dl2k driver. > IP1000A chip looks like a TC9020 with integrated PHY. > > Tested with Asus NX1101. You're saying the PHY support is incomplete, so gigabit isn't even detected for these chips. So in a way

[RFC, RFT PATCH 1/2] dl2k: Add support for IP1000A-based cards

2015-08-23 Thread Ondrej Zary
Add support for IP1000A chips to dl2k driver. IP1000A chip looks like a TC9020 with integrated PHY. Tested with Asus NX1101. --- drivers/net/ethernet/dlink/Kconfig |5 ++-- drivers/net/ethernet/dlink/dl2k.c | 51 +--- drivers/net/ethernet/dlink/dl2k.h |