Re: [PATCH 1/2] dmaengine: axi-dmac: Use devm_request_irq()

2018-04-26 Thread Moritz Fischer
Hi Lars, On Thu, Apr 26, 2018 at 9:26 AM, Lars-Peter Clausen wrote: > On 04/26/2018 06:12 PM, Moritz Fischer wrote: >> Use devm_request_irq() instead of request_irq() to request the IRQ. >> >> Signed-off-by: Moritz Fischer >> --- >> >> Hi Lars, >> >> was there

Re: [PATCH 1/2] dmaengine: axi-dmac: Use devm_request_irq()

2018-04-26 Thread Moritz Fischer
Hi Lars, On Thu, Apr 26, 2018 at 9:26 AM, Lars-Peter Clausen wrote: > On 04/26/2018 06:12 PM, Moritz Fischer wrote: >> Use devm_request_irq() instead of request_irq() to request the IRQ. >> >> Signed-off-by: Moritz Fischer >> --- >> >> Hi Lars, >> >> was there a specific reason not to use

Re: [PATCH 1/2] dmaengine: axi-dmac: Use devm_request_irq()

2018-04-26 Thread Lars-Peter Clausen
On 04/26/2018 06:12 PM, Moritz Fischer wrote: > Use devm_request_irq() instead of request_irq() to request the IRQ. > > Signed-off-by: Moritz Fischer > --- > > Hi Lars, > > was there a specific reason not to use devm_request_irq() ? Yes, it is wrong :) This reorders the

Re: [PATCH 1/2] dmaengine: axi-dmac: Use devm_request_irq()

2018-04-26 Thread Lars-Peter Clausen
On 04/26/2018 06:12 PM, Moritz Fischer wrote: > Use devm_request_irq() instead of request_irq() to request the IRQ. > > Signed-off-by: Moritz Fischer > --- > > Hi Lars, > > was there a specific reason not to use devm_request_irq() ? Yes, it is wrong :) This reorders the sequence in the

[PATCH 1/2] dmaengine: axi-dmac: Use devm_request_irq()

2018-04-26 Thread Moritz Fischer
Use devm_request_irq() instead of request_irq() to request the IRQ. Signed-off-by: Moritz Fischer --- Hi Lars, was there a specific reason not to use devm_request_irq() ? Cheers, Moritz --- drivers/dma/dma-axi-dmac.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH 1/2] dmaengine: axi-dmac: Use devm_request_irq()

2018-04-26 Thread Moritz Fischer
Use devm_request_irq() instead of request_irq() to request the IRQ. Signed-off-by: Moritz Fischer --- Hi Lars, was there a specific reason not to use devm_request_irq() ? Cheers, Moritz --- drivers/dma/dma-axi-dmac.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git