Re: [PATCH 1/2] dmaengine: hdmac: factorise memset descriptor allocation

2015-10-09 Thread Vinod Koul
On Wed, Oct 07, 2015 at 06:33:17PM +0100, Maxime Ripard wrote: > > This is fine, but this is driver limitation. We should really split the > > txn to multiple descriptors here.. > > Both these things are actually just copy from the previous code. > > I can probably fix the first style issue in th

Re: [PATCH 1/2] dmaengine: hdmac: factorise memset descriptor allocation

2015-10-07 Thread Maxime Ripard
Hi Vinod, On Wed, Oct 07, 2015 at 02:54:13PM +0100, Vinod Koul wrote: > On Thu, Oct 01, 2015 at 04:52:37PM +0200, Maxime Ripard wrote: > > > +static struct at_desc *atc_create_memset_desc(struct dma_chan *chan, > > + dma_addr_t psrc, > > +

Re: [PATCH 1/2] dmaengine: hdmac: factorise memset descriptor allocation

2015-10-07 Thread Vinod Koul
On Thu, Oct 01, 2015 at 04:52:37PM +0200, Maxime Ripard wrote: > +static struct at_desc *atc_create_memset_desc(struct dma_chan *chan, > + dma_addr_t psrc, > + dma_addr_t pdst, > +

[PATCH 1/2] dmaengine: hdmac: factorise memset descriptor allocation

2015-10-01 Thread Maxime Ripard
The memset and scatter gathered memset are going to use some common logic to create their descriptors. Move that logic into a function of its own so that we can share it with the future memset_sg callback. Signed-off-by: Maxime Ripard --- drivers/dma/at_hdmac.c | 98 +++