Re: [PATCH 1/2] driver: xen-blkfront: move talk_to_blkback to the correct place

2015-05-15 Thread Roger Pau Monné
El 15/05/15 a les 13.35, Bob Liu ha escrit: > > On 05/15/2015 07:14 PM, Roger Pau Monné wrote: >> El 15/05/15 a les 13.03, Bob Liu ha escrit: >>> >>> On 05/15/2015 06:01 PM, Roger Pau Monné wrote: El 12/05/15 a les 13.01, Bob Liu ha escrit: > The right place for talk_to_blkback() to query

Re: [PATCH 1/2] driver: xen-blkfront: move talk_to_blkback to the correct place

2015-05-15 Thread Bob Liu
On 05/15/2015 07:14 PM, Roger Pau Monné wrote: > El 15/05/15 a les 13.03, Bob Liu ha escrit: >> >> On 05/15/2015 06:01 PM, Roger Pau Monné wrote: >>> El 12/05/15 a les 13.01, Bob Liu ha escrit: The right place for talk_to_blkback() to query backend features and transport parameters

Re: [PATCH 1/2] driver: xen-blkfront: move talk_to_blkback to the correct place

2015-05-15 Thread Roger Pau Monné
El 15/05/15 a les 13.03, Bob Liu ha escrit: > > On 05/15/2015 06:01 PM, Roger Pau Monné wrote: >> El 12/05/15 a les 13.01, Bob Liu ha escrit: >>> The right place for talk_to_blkback() to query backend features and >>> transport >>> parameters is after backend entered XenbusStateInitWait. There is

Re: [PATCH 1/2] driver: xen-blkfront: move talk_to_blkback to the correct place

2015-05-15 Thread Bob Liu
On 05/15/2015 06:01 PM, Roger Pau Monné wrote: > El 12/05/15 a les 13.01, Bob Liu ha escrit: >> The right place for talk_to_blkback() to query backend features and transport >> parameters is after backend entered XenbusStateInitWait. There is no problem > > talk_to_blkback doesn't gather any back

Re: [PATCH 1/2] driver: xen-blkfront: move talk_to_blkback to the correct place

2015-05-15 Thread Roger Pau Monné
El 12/05/15 a les 13.01, Bob Liu ha escrit: > The right place for talk_to_blkback() to query backend features and transport > parameters is after backend entered XenbusStateInitWait. There is no problem talk_to_blkback doesn't gather any backend features, it just publishes the features supported b

[PATCH 1/2] driver: xen-blkfront: move talk_to_blkback to the correct place

2015-05-12 Thread Bob Liu
The right place for talk_to_blkback() to query backend features and transport parameters is after backend entered XenbusStateInitWait. There is no problem with this yet, but it is an violation of the design and furthermore it would not allow frontend/backend to negotiate 'multi-page' and 'multi-que