Re: [PATCH 1/2] drivers: clk: st: warn on iomap failure

2018-07-25 Thread Nicholas Mc Guire
On Wed, Jul 25, 2018 at 01:41:38PM -0700, Stephen Boyd wrote: > Quoting Nicholas Mc Guire (2018-07-15 03:18:23) > > While the return value of clkgen_get_register_base() is being checked > > at the call site, there is no indication of failure cause thus making > > diagnosis of the issues hard. The

Re: [PATCH 1/2] drivers: clk: st: warn on iomap failure

2018-07-25 Thread Nicholas Mc Guire
On Wed, Jul 25, 2018 at 01:41:38PM -0700, Stephen Boyd wrote: > Quoting Nicholas Mc Guire (2018-07-15 03:18:23) > > While the return value of clkgen_get_register_base() is being checked > > at the call site, there is no indication of failure cause thus making > > diagnosis of the issues hard. The

Re: [PATCH 1/2] drivers: clk: st: warn on iomap failure

2018-07-25 Thread Stephen Boyd
Quoting Nicholas Mc Guire (2018-07-15 03:18:23) > While the return value of clkgen_get_register_base() is being checked > at the call site, there is no indication of failure cause thus making > diagnosis of the issues hard. The WARN_ON() allows to determine the > cause of failure. > >

Re: [PATCH 1/2] drivers: clk: st: warn on iomap failure

2018-07-25 Thread Stephen Boyd
Quoting Nicholas Mc Guire (2018-07-15 03:18:23) > While the return value of clkgen_get_register_base() is being checked > at the call site, there is no indication of failure cause thus making > diagnosis of the issues hard. The WARN_ON() allows to determine the > cause of failure. > >

[PATCH 1/2] drivers: clk: st: warn on iomap failure

2018-07-15 Thread Nicholas Mc Guire
While the return value of clkgen_get_register_base() is being checked at the call site, there is no indication of failure cause thus making diagnosis of the issues hard. The WARN_ON() allows to determine the cause of failure. Signed-off-by: Nicholas Mc Guire --- Problem found by an

[PATCH 1/2] drivers: clk: st: warn on iomap failure

2018-07-15 Thread Nicholas Mc Guire
While the return value of clkgen_get_register_base() is being checked at the call site, there is no indication of failure cause thus making diagnosis of the issues hard. The WARN_ON() allows to determine the cause of failure. Signed-off-by: Nicholas Mc Guire --- Problem found by an