Re: [PATCH 1/2] drivers: qcom: rpmh-rsc: simplify TCS locking

2019-07-22 Thread Lina Iyer
On Mon, Jul 22 2019 at 12:18 -0600, Stephen Boyd wrote: Quoting Lina Iyer (2019-07-22 09:20:03) On Fri, Jul 19 2019 at 12:20 -0600, Stephen Boyd wrote: >Quoting Lina Iyer (2019-07-01 08:29:06) >> From: "Raju P.L.S.S.S.N" >> >> tcs->lock was introduced to serialize access with in TCS group. But

Re: [PATCH 1/2] drivers: qcom: rpmh-rsc: simplify TCS locking

2019-07-22 Thread Stephen Boyd
Quoting Lina Iyer (2019-07-22 09:20:03) > On Fri, Jul 19 2019 at 12:20 -0600, Stephen Boyd wrote: > >Quoting Lina Iyer (2019-07-01 08:29:06) > >> From: "Raju P.L.S.S.S.N" > >> > >> tcs->lock was introduced to serialize access with in TCS group. But > >> even without tcs->lock, drv->lock is serving

Re: [PATCH 1/2] drivers: qcom: rpmh-rsc: simplify TCS locking

2019-07-22 Thread Lina Iyer
On Fri, Jul 19 2019 at 12:20 -0600, Stephen Boyd wrote: Quoting Lina Iyer (2019-07-01 08:29:06) From: "Raju P.L.S.S.S.N" tcs->lock was introduced to serialize access with in TCS group. But even without tcs->lock, drv->lock is serving the same purpose. So use a single drv->lock. Isn't the dow

Re: [PATCH 1/2] drivers: qcom: rpmh-rsc: simplify TCS locking

2019-07-19 Thread Stephen Boyd
Quoting Lina Iyer (2019-07-01 08:29:06) > From: "Raju P.L.S.S.S.N" > > tcs->lock was introduced to serialize access with in TCS group. But > even without tcs->lock, drv->lock is serving the same purpose. So > use a single drv->lock. Isn't the downside now that we're going to be serializing acces

Re: [PATCH 1/2] drivers: qcom: rpmh-rsc: simplify TCS locking

2019-07-01 Thread Lina Iyer
Switching Andy's email address. On Mon, Jul 01 2019 at 09:32 -0600, Lina Iyer wrote: From: "Raju P.L.S.S.S.N" tcs->lock was introduced to serialize access with in TCS group. But even without tcs->lock, drv->lock is serving the same purpose. So use a single drv->lock. Other optimizations inclu

[PATCH 1/2] drivers: qcom: rpmh-rsc: simplify TCS locking

2019-07-01 Thread Lina Iyer
From: "Raju P.L.S.S.S.N" tcs->lock was introduced to serialize access with in TCS group. But even without tcs->lock, drv->lock is serving the same purpose. So use a single drv->lock. Other optimizations include - - Remove locking around clear_bit() in IRQ handler. clear_bit() is atomic. - R