Re: [PATCH 1/2] drm: make drm_dev_set_unique() not use a format string

2015-12-11 Thread Daniel Vetter
On Wed, Dec 09, 2015 at 12:52:58AM +0100, Nicolas Iooss wrote: > On 12/09/2015 12:28 AM, Emil Velikov wrote: > > On 8 December 2015 at 22:12, Nicolas Iooss > > wrote: > >> drm_dev_set_unique() uses a format string to define the unique name of a > >> device. This feature is not used as currently

Re: [PATCH 1/2] drm: make drm_dev_set_unique() not use a format string

2015-12-08 Thread Nicolas Iooss
On 12/09/2015 12:28 AM, Emil Velikov wrote: > On 8 December 2015 at 22:12, Nicolas Iooss > wrote: >> drm_dev_set_unique() uses a format string to define the unique name of a >> device. This feature is not used as currently all the calls to this >> function either use "%s" as a format string or d

Re: [PATCH 1/2] drm: make drm_dev_set_unique() not use a format string

2015-12-08 Thread Emil Velikov
On 8 December 2015 at 22:12, Nicolas Iooss wrote: > drm_dev_set_unique() uses a format string to define the unique name of a > device. This feature is not used as currently all the calls to this > function either use "%s" as a format string or directly use > dev_name(). > > Even though this secon

[PATCH 1/2] drm: make drm_dev_set_unique() not use a format string

2015-12-08 Thread Nicolas Iooss
drm_dev_set_unique() uses a format string to define the unique name of a device. This feature is not used as currently all the calls to this function either use "%s" as a format string or directly use dev_name(). Even though this second kind of call does not introduce security problems, because t