Re: [PATCH 1/2] drm: replace drm_[cm]alloc* by kvmalloc alternatives

2017-05-17 Thread Michal Hocko
On Wed 17-05-17 10:12:41, Chris Wilson wrote: > On Wed, May 17, 2017 at 11:03:50AM +0200, Michal Hocko wrote: [...] > > +static inline bool alloc_array_check(size_t n, size_t size) > > +{ > > + if (size != 0 && n > SIZE_MAX / size) > > + return false; > > + return true; > > Just retu

Re: [PATCH 1/2] drm: replace drm_[cm]alloc* by kvmalloc alternatives

2017-05-17 Thread Chris Wilson
On Wed, May 17, 2017 at 11:03:50AM +0200, Michal Hocko wrote: > On Wed 17-05-17 08:38:09, Chris Wilson wrote: > > On Wed, May 17, 2017 at 08:55:08AM +0200, Michal Hocko wrote: > > > From: Michal Hocko > > > > > > drm_[cm]alloc* has grown their own kvmalloc with vmalloc fallback > > > implementati

Re: [PATCH 1/2] drm: replace drm_[cm]alloc* by kvmalloc alternatives

2017-05-17 Thread Michal Hocko
On Wed 17-05-17 08:38:09, Chris Wilson wrote: > On Wed, May 17, 2017 at 08:55:08AM +0200, Michal Hocko wrote: > > From: Michal Hocko > > > > drm_[cm]alloc* has grown their own kvmalloc with vmalloc fallback > > implementations. MM has grown kvmalloc* helpers in the meantime. Let's > > use those b

Re: [PATCH 1/2] drm: replace drm_[cm]alloc* by kvmalloc alternatives

2017-05-17 Thread Chris Wilson
On Wed, May 17, 2017 at 08:55:08AM +0200, Michal Hocko wrote: > From: Michal Hocko > > drm_[cm]alloc* has grown their own kvmalloc with vmalloc fallback > implementations. MM has grown kvmalloc* helpers in the meantime. Let's > use those because it a) reduces the code and b) MM has a better idea

[PATCH 1/2] drm: replace drm_[cm]alloc* by kvmalloc alternatives

2017-05-16 Thread Michal Hocko
From: Michal Hocko drm_[cm]alloc* has grown their own kvmalloc with vmalloc fallback implementations. MM has grown kvmalloc* helpers in the meantime. Let's use those because it a) reduces the code and b) MM has a better idea how to implement fallbacks (e.g. do not vmalloc before kmalloc is tried