Re: [PATCH 1/2] dt-bindings: i2c: Add MediaTek i2c AC timing binding

2019-07-17 Thread Wolfram Sang
> > Can't you use those to derive your values from that? Which ones are you > > missing > > if not? > > I have take a little time to develop a new patch which based on your > suggestions, and it tested OK. Thanks for your suggestions, I will > update the patch after I test it fully. Great

Re: [PATCH 1/2] dt-bindings: i2c: Add MediaTek i2c AC timing binding

2019-07-17 Thread Qii Wang
On Wed, 2019-06-26 at 15:39 +0200, Wolfram Sang wrote: > Hi, > > On Tue, Jun 11, 2019 at 04:11:54PM +0800, Qii Wang wrote: > > Add i2c AC timing binding to binding file. It can give the AC > > timing parameters to meet I2C specification at different speed. > > > > Signed-off-by: Qii Wang > > I

Re: [PATCH 1/2] dt-bindings: i2c: Add MediaTek i2c AC timing binding

2019-06-26 Thread Wolfram Sang
Hi, On Tue, Jun 11, 2019 at 04:11:54PM +0800, Qii Wang wrote: > Add i2c AC timing binding to binding file. It can give the AC > timing parameters to meet I2C specification at different speed. > > Signed-off-by: Qii Wang I think this is a too specific 1:1 mapping of your register set into DT

[PATCH 1/2] dt-bindings: i2c: Add MediaTek i2c AC timing binding

2019-06-11 Thread Qii Wang
Add i2c AC timing binding to binding file. It can give the AC timing parameters to meet I2C specification at different speed. Signed-off-by: Qii Wang --- .../devicetree/bindings/i2c/i2c-mt65xx.txt | 11 +++ 1 file changed, 11 insertions(+) diff --git