Re: [f2fs-dev] [PATCH 1/2] f2fs: disable the extent cache ops on high fragmented files

2013-11-20 Thread Haicheng Li
> Signed-off-by: Jaegeuk Kim Function looks good to me. But some nitpicking below for code cleanup.. > @@ -71,6 +71,9 @@ static int check_extent_cache(struct inode *inode, pgoff_t > pgofs, return value could be boolean? > pgoff_t start_fofs, end_fofs; > block_t start_blkaddr; > >

Re: [f2fs-dev] [PATCH 1/2] f2fs: disable the extent cache ops on high fragmented files

2013-11-20 Thread Haicheng Li
Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com Function looks good to me. But some nitpicking below for code cleanup.. @@ -71,6 +71,9 @@ static int check_extent_cache(struct inode *inode, pgoff_t pgofs, return value could be boolean? pgoff_t start_fofs, end_fofs; block_t

[PATCH 1/2] f2fs: disable the extent cache ops on high fragmented files

2013-11-18 Thread Jaegeuk Kim
The f2fs manages an extent cache to search a number of consecutive data blocks very quickly. However it conducts unnecessary cache operations if the file is highly fragmented with no valid extent cache. In such the case, we don't need to handle the extent cache, but just can disable the cache

[PATCH 1/2] f2fs: disable the extent cache ops on high fragmented files

2013-11-18 Thread Jaegeuk Kim
The f2fs manages an extent cache to search a number of consecutive data blocks very quickly. However it conducts unnecessary cache operations if the file is highly fragmented with no valid extent cache. In such the case, we don't need to handle the extent cache, but just can disable the cache