RE: [f2fs-dev] [PATCH 1/2] f2fs: handle failed bio allocation

2015-08-24 Thread Chao Yu
Hi Jaegeuk, > -Original Message- > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > Sent: Monday, August 24, 2015 12:54 PM > To: Chao Yu > Cc: linux-kernel@vger.kernel.org; linux-fsde...@vger.kernel.org; > linux-f2fs-de...@lists.sourceforge.net > Subject: Re: [f2fs-

Re: [f2fs-dev] [PATCH 1/2] f2fs: handle failed bio allocation

2015-08-23 Thread Jaegeuk Kim
Hi Chao, [snip] > > > > > > > > - /* No failure on bio allocation */ > > > > - bio = bio_alloc(GFP_NOIO, npages); > > > > > > How about using __GFP_NOFAIL flag to avoid failing in bio_alloc instead > > > of adding opencode endless loop in code? > > > > > > We can see the reason in thi

RE: [f2fs-dev] [PATCH 1/2] f2fs: handle failed bio allocation

2015-08-21 Thread Chao Yu
; > > To: linux-kernel@vger.kernel.org; linux-fsde...@vger.kernel.org; > > > linux-f2fs-de...@lists.sourceforge.net > > > Cc: Jaegeuk Kim > > > Subject: [f2fs-dev] [PATCH 1/2] f2fs: handle failed bio allocation > > > > > > As the below commen

Re: [f2fs-dev] [PATCH 1/2] f2fs: handle failed bio allocation

2015-08-20 Thread Jaegeuk Kim
.kernel.org; > > linux-f2fs-de...@lists.sourceforge.net > > Cc: Jaegeuk Kim > > Subject: [f2fs-dev] [PATCH 1/2] f2fs: handle failed bio allocation > > > > As the below comment of bio_alloc_bioset, f2fs can allocate multiple bios > > at the > > same time. So, we can&

RE: [f2fs-dev] [PATCH 1/2] f2fs: handle failed bio allocation

2015-08-20 Thread Chao Yu
Hi Jaegeuk, > -Original Message- > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > Sent: Saturday, August 15, 2015 7:09 AM > To: linux-kernel@vger.kernel.org; linux-fsde...@vger.kernel.org; > linux-f2fs-de...@lists.sourceforge.net > Cc: Jaegeuk Kim > Subject: [f2fs-

[PATCH 1/2] f2fs: handle failed bio allocation

2015-08-14 Thread Jaegeuk Kim
As the below comment of bio_alloc_bioset, f2fs can allocate multiple bios at the same time. So, we can't guarantee that bio is allocated all the time. " * When @bs is not NULL, if %__GFP_WAIT is set then bio_alloc will always be * able to allocate a bio. This is due to the mempool guarantees