Re: [PATCH 1/2] fbdev: Make deferred I/O work as advertized

2008-02-21 Thread Markus Armbruster
"Jaya Kumar" <[EMAIL PROTECTED]> writes: > On Thu, Feb 21, 2008 at 5:43 PM, Markus Armbruster <[EMAIL PROTECTED]> wrote: >> Fix extracted from this linux-fbdev-devel message: > > Hi Markus, > > Yes, this was discussed back in November on linux-mm and hence my > patch. I didn't push for it to be m

Re: [PATCH 1/2] fbdev: Make deferred I/O work as advertized

2008-02-21 Thread Jaya Kumar
On Thu, Feb 21, 2008 at 5:43 PM, Markus Armbruster <[EMAIL PROTECTED]> wrote: > Fix extracted from this linux-fbdev-devel message: Hi Markus, Yes, this was discussed back in November on linux-mm and hence my patch. I didn't push for it to be merged by itself because I don't think it makes sense

[PATCH 1/2] fbdev: Make deferred I/O work as advertized

2008-02-21 Thread Markus Armbruster
Deferred I/O was utterly broken. Reading the mmap()ed framebuffer worked, but writing it made the VM endlessly invoke vm_ops.page_mkwrite(). That happened because we failed to set page->mapping and page->index. The fix is to set them, and clean up properly before the framebuffer gets released.