Re: [PATCH 1/2] firmware, fix request_firmware_nowait() freeze with no uevent

2013-10-24 Thread Prarit Bhargava
On 10/24/2013 07:17 AM, Henrique de Moraes Holschuh wrote: > On Wed, 23 Oct 2013, Prarit Bhargava wrote: >> After all this I completely forgot the problem I'm trying to solve here. The >> issue is that with HOTPLUG & request_microcode_nowait(), if the microcode >> image >> is not found (that is

Re: [PATCH 1/2] firmware, fix request_firmware_nowait() freeze with no uevent

2013-10-24 Thread Henrique de Moraes Holschuh
On Wed, 23 Oct 2013, Prarit Bhargava wrote: > After all this I completely forgot the problem I'm trying to solve here. The > issue is that with HOTPLUG & request_microcode_nowait(), if the microcode > image > is not found (that is the file is not found on disk), then EACH cpu waits 1 > minute and

Re: [PATCH 1/2] firmware, fix request_firmware_nowait() freeze with no uevent

2013-10-23 Thread Ming Lei
On Wed, Oct 23, 2013 at 10:08 PM, Prarit Bhargava wrote: > > > On 10/23/2013 09:21 AM, Ming Lei wrote: >> On Wed, Oct 23, 2013 at 8:02 PM, Prarit Bhargava wrote: >> >>> >>> After all this I completely forgot the problem I'm trying to solve here. >>> The >>> issue is that with HOTPLUG & request_

Re: [PATCH 1/2] firmware, fix request_firmware_nowait() freeze with no uevent

2013-10-23 Thread Prarit Bhargava
On 10/23/2013 09:21 AM, Ming Lei wrote: > On Wed, Oct 23, 2013 at 8:02 PM, Prarit Bhargava wrote: > >> >> After all this I completely forgot the problem I'm trying to solve here. The >> issue is that with HOTPLUG & request_microcode_nowait(), if the microcode >> image >> is not found (that is

Re: [PATCH 1/2] firmware, fix request_firmware_nowait() freeze with no uevent

2013-10-23 Thread Ming Lei
On Wed, Oct 23, 2013 at 8:02 PM, Prarit Bhargava wrote: > > After all this I completely forgot the problem I'm trying to solve here. The > issue is that with HOTPLUG & request_microcode_nowait(), if the microcode > image > is not found (that is the file is not found on disk), then EACH cpu wait

Re: [PATCH 1/2] firmware, fix request_firmware_nowait() freeze with no uevent

2013-10-23 Thread Prarit Bhargava
On 10/23/2013 06:36 AM, Prarit Bhargava wrote: > > > On 10/23/2013 12:16 AM, Ming Lei wrote: >> On Wed, Oct 23, 2013 at 7:15 AM, Prarit Bhargava wrote: >>> On 10/21/2013 10:35 PM, Ming Lei wrote: That is why NOHOTPLUG isn't encouraged to be taken, actually I don't suggest you to

Re: [PATCH 1/2] firmware, fix request_firmware_nowait() freeze with no uevent

2013-10-23 Thread Prarit Bhargava
On 10/23/2013 12:16 AM, Ming Lei wrote: > On Wed, Oct 23, 2013 at 7:15 AM, Prarit Bhargava wrote: >> On 10/21/2013 10:35 PM, Ming Lei wrote: >>> >>> That is why NOHOTPLUG isn't encouraged to be taken, actually >>> I don't suggest you to do that too, :-) >> Okay ... I can certainly switch to HOTP

Re: [PATCH 1/2] firmware, fix request_firmware_nowait() freeze with no uevent

2013-10-22 Thread Ming Lei
On Wed, Oct 23, 2013 at 7:15 AM, Prarit Bhargava wrote: > On 10/21/2013 10:35 PM, Ming Lei wrote: >> >> That is why NOHOTPLUG isn't encouraged to be taken, actually >> I don't suggest you to do that too, :-) > Okay ... I can certainly switch to HOTPLUG. OK, that should be the right approach. > >

Re: [PATCH 1/2] firmware, fix request_firmware_nowait() freeze with no uevent

2013-10-22 Thread Prarit Bhargava
On 10/21/2013 10:35 PM, Ming Lei wrote: > On Tue, Oct 22, 2013 at 6:24 AM, Prarit Bhargava wrote: >> >> >> On 10/21/2013 08:24 AM, Ming Lei wrote: >>> On Mon, Oct 21, 2013 at 5:35 AM, Prarit Bhargava wrote: If request_firmware_nowait() is called with uevent == NULL, the firmware complet

Re: [PATCH 1/2] firmware, fix request_firmware_nowait() freeze with no uevent

2013-10-21 Thread Ming Lei
On Tue, Oct 22, 2013 at 6:24 AM, Prarit Bhargava wrote: > > > On 10/21/2013 08:24 AM, Ming Lei wrote: >> On Mon, Oct 21, 2013 at 5:35 AM, Prarit Bhargava wrote: >>> If request_firmware_nowait() is called with uevent == NULL, the firmware >>> completion is never marked complete resulting in a hang

Re: [PATCH 1/2] firmware, fix request_firmware_nowait() freeze with no uevent

2013-10-21 Thread Prarit Bhargava
On 10/21/2013 08:24 AM, Ming Lei wrote: > On Mon, Oct 21, 2013 at 5:35 AM, Prarit Bhargava wrote: >> If request_firmware_nowait() is called with uevent == NULL, the firmware >> completion is never marked complete resulting in a hang in the process. >> >> If uevent is undefined, that means we're

Re: [PATCH 1/2] firmware, fix request_firmware_nowait() freeze with no uevent

2013-10-21 Thread Ming Lei
On Mon, Oct 21, 2013 at 5:35 AM, Prarit Bhargava wrote: > If request_firmware_nowait() is called with uevent == NULL, the firmware > completion is never marked complete resulting in a hang in the process. > > If uevent is undefined, that means we're not waiting on anything and the > process should

[PATCH 1/2] firmware, fix request_firmware_nowait() freeze with no uevent

2013-10-20 Thread Prarit Bhargava
If request_firmware_nowait() is called with uevent == NULL, the firmware completion is never marked complete resulting in a hang in the process. If uevent is undefined, that means we're not waiting on anything and the process should just clean up and complete. While we're at it, add a debug dev_d