Re: [PATCH 1/2] fsl_hypervisor: dereferencing error pointers in ioctl

2019-04-04 Thread Dan Carpenter
On Thu, Apr 04, 2019 at 12:10:44PM -0700, Andrew Morton wrote: > On Tue, 18 Dec 2018 11:20:03 +0300 Dan Carpenter > wrote: > > > The strndup_user() function returns error pointers on error, and then > > in the error handling we pass the error pointers to kfree(). It will > > cause an Oops. > >

Re: [PATCH 1/2] fsl_hypervisor: dereferencing error pointers in ioctl

2019-04-04 Thread Andrew Morton
On Tue, 18 Dec 2018 11:20:03 +0300 Dan Carpenter wrote: > The strndup_user() function returns error pointers on error, and then > in the error handling we pass the error pointers to kfree(). It will > cause an Oops. > Looks good to me. I guess we should fix this too? From: Andrew Morton

Re: [PATCH 1/2] fsl_hypervisor: dereferencing error pointers in ioctl

2019-04-04 Thread Dan Carpenter
I sent this patch series right before Christmas so everyone was on holiday. It still applies fine. Could you take a look at it? regards, dan carpenter

[PATCH 1/2] fsl_hypervisor: dereferencing error pointers in ioctl

2018-12-18 Thread Dan Carpenter
The strndup_user() function returns error pointers on error, and then in the error handling we pass the error pointers to kfree(). It will cause an Oops. Fixes: 6db7199407ca ("drivers/virt: introduce Freescale hypervisor management driver") Signed-off-by: Dan Carpenter ---