Re: [PATCH 1/2] genirq: add chip_{suspend,resume} PM support to irq_chip

2015-07-22 Thread Brian Norris
On Tue, Jul 21, 2015 at 11:58:01PM +0200, Thomas Gleixner wrote: > On Tue, 21 Jul 2015, Florian Fainelli wrote: > > On 21/07/15 14:23, Thomas Gleixner wrote: > > > I just read back on the problem report which was mentioned in the > > > changelog: > > > > > > "It's not a problem with patch 7, exact

Re: [PATCH 1/2] genirq: add chip_{suspend,resume} PM support to irq_chip

2015-07-21 Thread Thomas Gleixner
On Tue, 21 Jul 2015, Florian Fainelli wrote: > On 21/07/15 14:23, Thomas Gleixner wrote: > > I just read back on the problem report which was mentioned in the > > changelog: > > > > "It's not a problem with patch 7, exactly, it's a problem with the > > irqchip driver which handles the UART interr

Re: [PATCH 1/2] genirq: add chip_{suspend,resume} PM support to irq_chip

2015-07-21 Thread Brian Norris
Hi Florian, Thomas, On Tue, Jul 21, 2015 at 11:24:29AM -0700, Florian Fainelli wrote: > On 20/06/15 07:11, Thomas Gleixner wrote: > > On Fri, 19 Jun 2015, Brian Norris wrote: ... > > I really don't want to set a precedent for random (*foo)(*bar) > > callbacks. > > > >> + > >> + if (ct->

Re: [PATCH 1/2] genirq: add chip_{suspend,resume} PM support to irq_chip

2015-07-21 Thread Florian Fainelli
On 21/07/15 14:23, Thomas Gleixner wrote: > On Tue, 21 Jul 2015, Florian Fainelli wrote: >> On 20/06/15 07:11, Thomas Gleixner wrote: >>> On Fri, 19 Jun 2015, Brian Norris wrote: This patch adds a second set of suspend/resume hooks to irq_chip, this time to represent *chip* suspend/resume

Re: [PATCH 1/2] genirq: add chip_{suspend,resume} PM support to irq_chip

2015-07-21 Thread Thomas Gleixner
On Tue, 21 Jul 2015, Florian Fainelli wrote: > On 20/06/15 07:11, Thomas Gleixner wrote: > > On Fri, 19 Jun 2015, Brian Norris wrote: > >> This patch adds a second set of suspend/resume hooks to irq_chip, this > >> time to represent *chip* suspend/resume, rather than IRQ suspend/resume. > >> These

Re: [PATCH 1/2] genirq: add chip_{suspend,resume} PM support to irq_chip

2015-07-21 Thread Florian Fainelli
On 20/06/15 07:11, Thomas Gleixner wrote: > On Fri, 19 Jun 2015, Brian Norris wrote: >> This patch adds a second set of suspend/resume hooks to irq_chip, this >> time to represent *chip* suspend/resume, rather than IRQ suspend/resume. >> These callbacks will always be called for an irqchip and are

Re: [PATCH 1/2] genirq: add chip_{suspend,resume} PM support to irq_chip

2015-06-20 Thread Thomas Gleixner
On Fri, 19 Jun 2015, Brian Norris wrote: > This patch adds a second set of suspend/resume hooks to irq_chip, this > time to represent *chip* suspend/resume, rather than IRQ suspend/resume. > These callbacks will always be called for an irqchip and are based on > the per-chip irq_chip_generic struct

Re: [PATCH 1/2] genirq: add chip_{suspend,resume} PM support to irq_chip

2015-06-19 Thread Florian Fainelli
On 19/06/15 16:26, Brian Norris wrote: > Some (admittedly odd) irqchips perform functions that are not directly > related to any of their child IRQ lines, and therefore need to perform > some tasks during suspend/resume regardless of whether there are > any "installed" interrupts for the irqchip. H

[PATCH 1/2] genirq: add chip_{suspend,resume} PM support to irq_chip

2015-06-19 Thread Brian Norris
Some (admittedly odd) irqchips perform functions that are not directly related to any of their child IRQ lines, and therefore need to perform some tasks during suspend/resume regardless of whether there are any "installed" interrupts for the irqchip. However, the current generic-chip framework does