Re: [PATCH 1/2] gpio: gpio-generic: Fix bug in big endian bit conversion

2013-03-03 Thread Grant Likely
On Tue, 26 Feb 2013 11:46:31 +0100, Andreas Larsson wrote: > On 2013-02-26 08:52, Grant Likely wrote: > > On Sat, 09 Feb 2013 14:58:55 +, Grant Likely > > wrote: > >> On Tue, 5 Feb 2013 11:33:02 +0100, Andreas Larsson > >> wrote: > >>> The swap to convert LE to BE in bgpio_pin2mask_be sho

Re: [PATCH 1/2] gpio: gpio-generic: Fix bug in big endian bit conversion

2013-02-26 Thread Andreas Larsson
On 2013-02-26 11:46, Andreas Larsson wrote: On 2013-02-26 08:52, Grant Likely wrote: On Sat, 09 Feb 2013 14:58:55 +, Grant Likely wrote: We /could/ have a ioread32be/write32be mode in the driver, but I don't think that is the right approach. It means we need yet another set of accessors for

Re: [PATCH 1/2] gpio: gpio-generic: Fix bug in big endian bit conversion

2013-02-26 Thread Andreas Larsson
On 2013-02-26 08:52, Grant Likely wrote: On Sat, 09 Feb 2013 14:58:55 +, Grant Likely wrote: On Tue, 5 Feb 2013 11:33:02 +0100, Andreas Larsson wrote: The swap to convert LE to BE in bgpio_pin2mask_be should be on byte level, not on bit level. Signed-off-by: Andreas Larsson --- driv

Re: [PATCH 1/2] gpio: gpio-generic: Fix bug in big endian bit conversion

2013-02-25 Thread Grant Likely
On Sat, 09 Feb 2013 14:58:55 +, Grant Likely wrote: > On Tue, 5 Feb 2013 11:33:02 +0100, Andreas Larsson > wrote: > > The swap to convert LE to BE in bgpio_pin2mask_be should be on byte level, > > not > > on bit level. > > > > Signed-off-by: Andreas Larsson > > --- > > drivers/gpio/gpi

Re: [PATCH 1/2] gpio: gpio-generic: Fix bug in big endian bit conversion

2013-02-09 Thread Grant Likely
On Tue, 5 Feb 2013 11:33:02 +0100, Andreas Larsson wrote: > The swap to convert LE to BE in bgpio_pin2mask_be should be on byte level, not > on bit level. > > Signed-off-by: Andreas Larsson > --- > drivers/gpio/gpio-generic.c |5 - > 1 files changed, 4 insertions(+), 1 deletions(-) >

[PATCH 1/2] gpio: gpio-generic: Fix bug in big endian bit conversion

2013-02-05 Thread Andreas Larsson
The swap to convert LE to BE in bgpio_pin2mask_be should be on byte level, not on bit level. Signed-off-by: Andreas Larsson --- drivers/gpio/gpio-generic.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/gpio/gpio-generic.c b/drivers/gpio/gpio-generic.c index